From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D58BEEB64D9 for ; Tue, 27 Jun 2023 09:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dbriAffJ1unga5bto5NeGChx9Q6orsfp0si7bE6TEPs=; b=XuoQLE3O+aSQeb bXKvZCCiQ4oHzo1D56I0L2TvOQmPOZxBy8JMYq31R1lF/4J6MGyt2aAJceyS2crkRCM3ky1Jzaucf 4lPO26YayqtxWD+W+LSXNg+L12IOc/tzkZxXmYvJypCxflcLvfNZd5e0fOCLWxsg5SCn8afIQa2/s cqesojw4hQ8ql5v+9yoR1AjRx4cpuddTHHRBDFL96c9J28ZFEVAVDUOVDMmg7grbCtPyekJLaV8Gj Lm0tPyWMshlWxyRNMrPCh1fyG7QCQ6igki4AtwZly4jPZvYYtKZEYl8klX7CaNLAYbIkrLIAzTLpO TemdQRZM2cF+nEZBvXUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qE4jA-00CesO-0y; Tue, 27 Jun 2023 09:11:12 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qE4j6-00Ceq0-28 for linux-riscv@lists.infradead.org; Tue, 27 Jun 2023 09:11:10 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-991b7a4d2e8so252177066b.1 for ; Tue, 27 Jun 2023 02:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1687857066; x=1690449066; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MpzTw3E7Z1hiaRKO3mrWVuNDi99XvZiDXNO0HWAlUSI=; b=QSbolgKuWBtTP13NnqwJj/MLdAunJIZ6gtz5oOH0Gk/6uu5TXD3aDKDtckngzeGNaE 1divA1wajXFvZ959P2P+ecVS56HtJWwKO5XYGX0JXEuYv6O05YsmkbaJIdCG/KL7/D10 uHEgJAb7XNFWgRbEDEIIJ4I4sZ9N739G6DGlqAlMaT5P42qCLKyHgYCbKoqfG4iTAKAx bI1OoTRkfyOhA46nTLx7ebwlkZpdnr8u5LXchC20fCpLld228zc/vEqpWyQD9aAoB47D lerSIo0JkhbQ8MVSsOZDGbfhT7fNhyaPuOcCJRfbgyLEzvbkW+Le68KX/VsjoMKN7tK9 YR3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687857066; x=1690449066; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MpzTw3E7Z1hiaRKO3mrWVuNDi99XvZiDXNO0HWAlUSI=; b=BBHKPS3InRiM+1EO7/UQIwWuh3Lsn9BwSJ2ETXE6ePIPKIaEDzVwfPmQNj2yrfSDW4 dZTRd92zTKEzHmXoWCjQZNtdRVFAnTbFpJ6DNsPwuhLbSWG7Gz9wBYLNX9dUit7F5dRr rQp8mRSVmF4poa3rfBOj+vrx9OvoRXxgYRWS1qFoka0ES5N8JL8nAI3NC+5Ei7hLjb4C 7qkjIn10O2qeEX7ii9amQYS6pR5v2j4tKPHQ9+hlFI3MckbfH/+rOxJVhZzI7XCXLtCe PnJYyIt3zVzbS0I+VDvuF25z5RbEZnygE6Rpe3h3djm6U26xLkQ+B0JAvXnUd8wbfGxw 2BBA== X-Gm-Message-State: AC+VfDymtIFX9XHgXUsz/eTlf/dvlOxXJQwj2+hLQJBLflrJMAQmgLmz SCIaMkItX7kMWR6QaWxSY6IZPg== X-Google-Smtp-Source: ACHHUZ450s4E0+V1ZLBeLohB3/YHAZdFg1IWiV0LH2NrGhbm/Wxox9eaLfHNxRxcEpnc0aueIWf7OQ== X-Received: by 2002:a17:906:5a59:b0:98d:f11e:4816 with SMTP id my25-20020a1709065a5900b0098df11e4816mr7286613ejc.29.1687857066569; Tue, 27 Jun 2023 02:11:06 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id ox27-20020a170907101b00b00988e81e1638sm4328436ejb.92.2023.06.27.02.11.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 02:11:06 -0700 (PDT) Date: Tue, 27 Jun 2023 11:11:05 +0200 From: Andrew Jones To: Haibo Xu Cc: xiaobo55x@gmail.com, maz@kernel.org, oliver.upton@linux.dev, seanjc@google.com, Paolo Bonzini , Jonathan Corbet , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Shuah Khan , James Morse , Suzuki K Poulose , Zenghui Yu , Ben Gardon , David Matlack , Ricardo Koller , Vishal Annapurve , Vipin Sharma , Colton Lewis , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 09/12] KVM: selftests: Only do get/set tests on present blessed list Message-ID: <20230627-adcb173b3ee813e2e16353bd@orel> References: <47f0502d076c071260a87953cbabadfc85d278cf.1687515463.git.haibo1.xu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <47f0502d076c071260a87953cbabadfc85d278cf.1687515463.git.haibo1.xu@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230627_021108_698695_BDE4ABE4 X-CRM114-Status: GOOD ( 24.15 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Jun 23, 2023 at 06:40:11PM +0800, Haibo Xu wrote: > Only do the get/set tests on present and blessed registers > since we don't know the capabilities of any new ones. > > Suggested-by: Andrew Jones > Signed-off-by: Haibo Xu > --- > tools/testing/selftests/kvm/get-reg-list.c | 29 ++++++++++++++-------- > 1 file changed, 18 insertions(+), 11 deletions(-) > > diff --git a/tools/testing/selftests/kvm/get-reg-list.c b/tools/testing/selftests/kvm/get-reg-list.c > index b956ee410996..3beb6b62de0a 100644 > --- a/tools/testing/selftests/kvm/get-reg-list.c > +++ b/tools/testing/selftests/kvm/get-reg-list.c > @@ -52,6 +52,10 @@ extern int vcpu_configs_n; > for_each_reg_filtered(i) \ > if (!find_reg(blessed_reg, blessed_n, reg_list->reg[i])) > > +#define for_each_present_blessed_reg(i) \ > + for ((i) = 0; (i) < blessed_n; ++(i)) \ > + if (find_reg(reg_list->reg, reg_list->n, blessed_reg[i])) > + > static const char *config_name(struct vcpu_reg_list *c) > { > struct vcpu_reg_sublist *s; > @@ -189,6 +193,16 @@ static void run_test(struct vcpu_reg_list *c) > return; > } > > + for_each_sublist(c, s) > + blessed_n += s->regs_n; > + blessed_reg = calloc(blessed_n, sizeof(__u64)); > + > + n = 0; > + for_each_sublist(c, s) { > + for (i = 0; i < s->regs_n; ++i) > + blessed_reg[n++] = s->regs[i]; > + } > + > /* > * We only test that we can get the register and then write back the > * same value. Some registers may allow other values to be written > @@ -198,8 +212,11 @@ static void run_test(struct vcpu_reg_list *c) > * be written need to have the other values tested, then we should > * create a new set of tests for those in a new independent test > * executable. > + * > + * Only do the get/set tests on present, blessed list registers, > + * since we don't know the capabilities of any new registers. > */ > - for_each_reg(i) { > + for_each_present_blessed_reg(i) { > uint8_t addr[2048 / 8]; > struct kvm_one_reg reg = { > .id = reg_list->reg[i], > @@ -242,16 +259,6 @@ static void run_test(struct vcpu_reg_list *c) > } > } > > - for_each_sublist(c, s) > - blessed_n += s->regs_n; > - blessed_reg = calloc(blessed_n, sizeof(__u64)); > - > - n = 0; > - for_each_sublist(c, s) { > - for (i = 0; i < s->regs_n; ++i) > - blessed_reg[n++] = s->regs[i]; > - } > - > for_each_new_reg(i) > ++new_regs; > > -- > 2.34.1 > Reviewed-by: Andrew Jones Thanks, drew _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv