Re: [PATCH v2 3/3] riscv: obtain SMBIOS entry from FFI.

From: Conor Dooley <conor@kernel.org>
To: Yunhui Cui <cuiyunhui@bytedance.com>
Cc: ardb@kernel.org, palmer@dabbelt.com, paul.walmsley@sifive.com,
	aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
	rminnich@gmail.com, mark.rutland@arm.com, lpieralisi@kernel.org,
	rafael@kernel.org, lenb@kernel.org, jdelvare@suse.com,
	yc.hung@mediatek.com, angelogioacchino.delregno@collabora.com,
	allen-kh.cheng@mediatek.com,
	pierre-louis.bossart@linux.intel.com, tinghan.shen@mediatek.com,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	geshijian@bytedance.com, weidong.wd@bytedance.com
Subject: Re: [PATCH v2 3/3] riscv: obtain SMBIOS entry from FFI.
Date: Sun, 2 Jul 2023 13:42:34 +0100	[thread overview]
Message-ID: <20230702-confiding-aqueduct-25c3c2852de3@spud> (raw)
In-Reply-To: <20230702095735.860-3-cuiyunhui@bytedance.com>

[-- Attachment #1.1: Type: text/plain, Size: 983 bytes --]

Hey,

On Sun, Jul 02, 2023 at 05:57:34PM +0800, Yunhui Cui wrote:
> When we bringup with coreboot on riscv, we need to obtain
> the entry address of SMBIOS through the FFI scheme.

What do you need it for?

> 
> Signed-off-by: Yunhui Cui <cuiyunhui@bytedance.com>
> ---
>  arch/riscv/kernel/ffi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/riscv/kernel/ffi.c b/arch/riscv/kernel/ffi.c
> index c5ac2b5d9148..c44f943a1cb5 100644
> --- a/arch/riscv/kernel/ffi.c
> +++ b/arch/riscv/kernel/ffi.c
> @@ -8,6 +8,7 @@
>  #include <linux/of.h>
>  #include <linux/of_fdt.h>
>  #include <linux/libfdt.h>
> +#include <linux/ffi.h>
>  
>  u64 acpi_rsdp;
>  
> @@ -34,4 +35,7 @@ void __init ffi_acpi_root_pointer(void)
>  void __init ffi_init(void)
>  {
>  	ffi_acpi_root_pointer();
> +#if CONFIG_FDT_FW_INTERFACE
> +	ffi_smbios_root_pointer();
> +#endif

Please stub this function so that we don't need ifdeffery here.

Cheers,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv