Re: [PATCH bpf-next v2 2/3] riscv: implement a memset like function for text

From: kernel test robot <lkp@intel.com>
To: Puranjay Mohan <puranjay12@gmail.com>,
	paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, pulehui@huawei.com,
	conor.dooley@microchip.com, ast@kernel.org, daniel@iogearbox.net,
	andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
	yhs@fb.com, kpsingh@kernel.org, bjorn@kernel.org,
	bpf@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, puranjay12@gmail.com
Subject: Re: [PATCH bpf-next v2 2/3] riscv: implement a memset like function for text
Date: Fri, 25 Aug 2023 09:26:29 +0800	[thread overview]
Message-ID: <202308250924.NlFcBoND-lkp@intel.com> (raw)
In-Reply-To: <20230824133135.1176709-3-puranjay12@gmail.com>

Hi Puranjay,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Puranjay-Mohan/riscv-extend-patch_text_nosync-for-multiple-pages/20230824-213410
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20230824133135.1176709-3-puranjay12%40gmail.com
patch subject: [PATCH bpf-next v2 2/3] riscv: implement a memset like function for text
config: riscv-allnoconfig (https://download.01.org/0day-ci/archive/20230825/202308250924.NlFcBoND-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230825/202308250924.NlFcBoND-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308250924.NlFcBoND-lkp@intel.com/

All warnings (new ones prefixed by >>):

   arch/riscv/kernel/patch.c: In function '__patch_insn_set':
>> arch/riscv/kernel/patch.c:61:13: warning: unused variable 'ret' [-Wunused-variable]
      61 |         int ret;
         |             ^~~

vim +/ret +61 arch/riscv/kernel/patch.c

    56	
    57	static int __patch_insn_set(void *addr, const int c, size_t len)
    58	{
    59		void *waddr = addr;
    60		bool across_pages = (((uintptr_t) addr & ~PAGE_MASK) + len) > PAGE_SIZE;
  > 61		int ret;
    62	
    63		/*
    64		 * Only two pages can be mapped at a time for writing.
    65		 */
    66		if (len > 2 * PAGE_SIZE)
    67			return -EINVAL;
    68	
    69		if (across_pages)
    70			patch_map(addr + PAGE_SIZE, FIX_TEXT_POKE1);
    71	
    72		waddr = patch_map(addr, FIX_TEXT_POKE0);
    73	
    74		memset(waddr, c, len);
    75	
    76		patch_unmap(FIX_TEXT_POKE0);
    77	
    78		if (across_pages)
    79			patch_unmap(FIX_TEXT_POKE1);
    80	
    81		return 0;
    82	}
    83	NOKPROBE_SYMBOL(__patch_insn_set);
    84	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv