Re: [RFC PATCH 2/5] RISC-V: selftests: Replace cpu_count with cpusetsize

Palmer Dabbelt
2023-09-25T11:23:40Z

On Thu, 21 Sep 2023 05:55:21 PDT (-0700), ajones@ventanamicro.com wrote:
> Use 'cpusetsize' instead of 'cpu_count' for the size of the cpu
> set parameter of the hwprobe syscall.
>
> Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
> ---
> tools/testing/selftests/riscv/hwprobe/hwprobe.c | 2 +-
> tools/testing/selftests/riscv/hwprobe/hwprobe.h | 2 +-
> tools/testing/selftests/riscv/vector/vstate_prctl.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/riscv/hwprobe/hwprobe.c b/tools/testing/selftests/riscv/hwprobe/hwprobe.c
> index c474891df307..d53e0889b59e 100644
> --- a/tools/testing/selftests/riscv/hwprobe/hwprobe.c
> +++ b/tools/testing/selftests/riscv/hwprobe/hwprobe.c
> @@ -47,7 +47,7 @@ int main(int argc, char **argv)
> ksft_test_result(out != 0, "Bad CPU set\n");
>
> out = riscv_hwprobe(pairs, 8, 1, 0, 0);
> - ksft_test_result(out != 0, "NULL CPU set with non-zero count\n");
> + ksft_test_result(out != 0, "NULL CPU set with non-zero size\n");
>
> pairs[0].key = RISCV_HWPROBE_KEY_BASE_BEHAVIOR;
> out = riscv_hwprobe(pairs, 1, 1, &cpus, 0);
> diff --git a/tools/testing/selftests/riscv/hwprobe/hwprobe.h b/tools/testing/selftests/riscv/hwprobe/hwprobe.h
> index 721b0ce73a56..e3fccb390c4d 100644
> --- a/tools/testing/selftests/riscv/hwprobe/hwprobe.h
> +++ b/tools/testing/selftests/riscv/hwprobe/hwprobe.h
> @@ -10,6 +10,6 @@
> * contain the call.
> */
> long riscv_hwprobe(struct riscv_hwprobe *pairs, size_t pair_count,
> - size_t cpu_count, unsigned long *cpus, unsigned int flags);
> + size_t cpusetsize, unsigned long *cpus, unsigned int flags);
>
> #endif
> diff --git a/tools/testing/selftests/riscv/vector/vstate_prctl.c b/tools/testing/selftests/riscv/vector/vstate_prctl.c
> index b348b475be57..540fe588e78f 100644
> --- a/tools/testing/selftests/riscv/vector/vstate_prctl.c
> +++ b/tools/testing/selftests/riscv/vector/vstate_prctl.c
> @@ -13,7 +13,7 @@
> * contain the call.
> */
> long riscv_hwprobe(struct riscv_hwprobe *pairs, size_t pair_count,
> - size_t cpu_count, unsigned long *cpus, unsigned int flags);
> + size_t cpusetsize, unsigned long *cpus, unsigned int flags);
>
> #define NEXT_PROGRAM "./vstate_exec_nolibc"
> static int launch_test(int test_inherit)

Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>