From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B2EECD8CA9 for ; Tue, 10 Oct 2023 17:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2GokvN6kuiaQA0+RnyyYe1PxjB9wB4pPBIeeUIIleJk=; b=NOXtH8YpfVL5IY eICrf+NQc4SFVKnS0WZrZh9EKtZlr7o0P1ZUPRp5GUFIuyrjQbqy63MhWo45vJ8g0JLZEkSPFOx+B o0XHRKpbQaa01jz1UJjWmOmsK+Rl7xBUfN+kW8ouYQIbCZoXJCg1eZvsZoL5POzJO7rLeWSUxmhKU dhFfJAksT90Q2hUFjATZZHA0UoGBYPfYtHupMfDcjfeW2OrEO/QFnQ7211ynVZS2WiyweGshr7DL7 +qL8beLkNtE1q81mKj6WS85IvGDftEfwPcvm758kkRsbGjeanTUCLNEOL1ELDPSRZR1Clo7TWTH74 4/AcIQWozcZkjNBVFv+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqGKh-00Dq5q-1a; Tue, 10 Oct 2023 17:15:47 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqGKc-00Dq4U-3C; Tue, 10 Oct 2023 17:15:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 8DA13B81CD0; Tue, 10 Oct 2023 17:15:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F03DC433C7; Tue, 10 Oct 2023 17:15:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696958140; bh=zjSBxk6UATy9y4pqLcR+ifaY1dYuZQpAMHpPto23JUA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kdZiTe7HCo50JWD0c5xwApJlmA9waTfbHKBmCL81h7/HGrq4Cm8fJxyWIYw3pemxr r6Q7kWEFiWquLyBo30s1WMkjWM0VnBmGyDUJnb7X4iGGqYbdWxUnY+UMyQOHkZj8CB MQj4XFDDpT/q2vtHSuAn2tBPx9taEVwTSaFuCWwA= Date: Tue, 10 Oct 2023 19:15:38 +0200 From: Greg Kroah-Hartman To: Anup Patel Cc: Paolo Bonzini , Atish Patra , Palmer Dabbelt , Paul Walmsley , Jiri Slaby , Conor Dooley , Andrew Jones , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] RISC-V: KVM: Forward SBI DBCN extension to user-space Message-ID: <2023101048-attach-drift-d77b@gregkh> References: <20231010170503.657189-1-apatel@ventanamicro.com> <20231010170503.657189-4-apatel@ventanamicro.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231010170503.657189-4-apatel@ventanamicro.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231010_101543_172701_2EC625AC X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Oct 10, 2023 at 10:35:00PM +0530, Anup Patel wrote: > The SBI DBCN extension needs to be emulated in user-space Why? > so let > us forward console_puts() call to user-space. What could go wrong! Why does userspace have to get involved in a console message? Why is this needed at all? The kernel can not handle userspace consoles as obviously they have to be re-entrant and irq safe. > > Signed-off-by: Anup Patel > --- > arch/riscv/include/asm/kvm_vcpu_sbi.h | 1 + > arch/riscv/include/uapi/asm/kvm.h | 1 + > arch/riscv/kvm/vcpu_sbi.c | 4 ++++ > arch/riscv/kvm/vcpu_sbi_replace.c | 31 +++++++++++++++++++++++++++ > 4 files changed, 37 insertions(+) > > diff --git a/arch/riscv/include/asm/kvm_vcpu_sbi.h b/arch/riscv/include/asm/kvm_vcpu_sbi.h > index 8d6d4dce8a5e..a85f95eb6e85 100644 > --- a/arch/riscv/include/asm/kvm_vcpu_sbi.h > +++ b/arch/riscv/include/asm/kvm_vcpu_sbi.h > @@ -69,6 +69,7 @@ extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_ipi; > extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_rfence; > extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_srst; > extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_hsm; > +extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_dbcn; > extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_experimental; > extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_vendor; > > diff --git a/arch/riscv/include/uapi/asm/kvm.h b/arch/riscv/include/uapi/asm/kvm.h > index 917d8cc2489e..60d3b21dead7 100644 > --- a/arch/riscv/include/uapi/asm/kvm.h > +++ b/arch/riscv/include/uapi/asm/kvm.h > @@ -156,6 +156,7 @@ enum KVM_RISCV_SBI_EXT_ID { > KVM_RISCV_SBI_EXT_PMU, > KVM_RISCV_SBI_EXT_EXPERIMENTAL, > KVM_RISCV_SBI_EXT_VENDOR, > + KVM_RISCV_SBI_EXT_DBCN, > KVM_RISCV_SBI_EXT_MAX, You just broke a user/kernel ABI here, why? thanks, greg k-h _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv