public inbox for linux-riscv@lists.infradead.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Andrew Jones <ajones@ventanamicro.com>
Cc: linux-riscv@lists.infradead.org, paul.walmsley@sifive.com,
	palmer@dabbelt.com, aou@eecs.berkeley.edu, evan@rivosinc.com,
	conor.dooley@microchip.com, apatel@ventanamicro.com,
	Palmer Dabbelt <palmer@rivosinc.com>
Subject: Re: [PATCH v1 1/6] RISC-V: hwprobe: Clarify cpus size parameter
Date: Thu, 12 Oct 2023 14:38:08 +0100	[thread overview]
Message-ID: <20231012-riverbed-surprise-d5aa8adb6110@spud> (raw)
In-Reply-To: <20231011135610.122850-9-ajones@ventanamicro.com>


[-- Attachment #1.1: Type: text/plain, Size: 900 bytes --]

On Wed, Oct 11, 2023 at 03:56:12PM +0200, Andrew Jones wrote:
> The "count" parameter associated with the 'cpus' parameter of the
> hwprobe syscall is the size in bytes of 'cpus'. Naming it 'cpu_count'
> may mislead users (it did me) to think it's the number of CPUs that
> are or can be represented by 'cpus' instead. This is particularly
> easy (IMO) to get wrong since 'cpus' is documented to be defined by
> CPU_SET(3) and CPU_SET(3) also documents a CPU_COUNT() (the number
> of CPUs in set) macro. CPU_SET(3) refers to the size of cpu sets
> with 'setsize'. Adopt 'cpusetsize' for the hwprobe parameter and
> specifically state it is in bytes in Documentation/riscv/hwprobe.rst
> to clarify.
> 
> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
> Signed-off-by: Andrew Jones <ajones@ventanamicro.com>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2023-10-12 13:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 13:56 [PATCH v1 0/6] RISC-V: hwprobe: Introduce which-cpus Andrew Jones
2023-10-11 13:56 ` [PATCH v1 1/6] RISC-V: hwprobe: Clarify cpus size parameter Andrew Jones
2023-10-12 13:38   ` Conor Dooley [this message]
2023-10-11 13:56 ` [PATCH v1 2/6] RISC-V: Move the hwprobe syscall to its own file Andrew Jones
2023-10-12 13:45   ` Conor Dooley
2023-10-12 16:11     ` Andrew Jones
2023-10-12 16:42       ` Evan Green
2023-10-12 17:02         ` Conor Dooley
2023-10-13  6:45           ` Andrew Jones
2023-10-13  7:39             ` Conor Dooley
2023-10-13 15:26               ` Evan Green
2023-10-11 13:56 ` [PATCH v1 3/6] RISC-V: hwprobe: Introduce which-cpus flag Andrew Jones
2023-10-12 17:40   ` Evan Green
2023-10-13  7:20     ` Andrew Jones
2023-10-19 17:16   ` Andrew Jones
2023-10-11 13:56 ` [PATCH v1 4/6] RISC-V: selftests: Statically link hwprobe test Andrew Jones
2023-10-11 13:56 ` [PATCH v1 5/6] RISC-V: selftests: Convert hwprobe test to kselftest API Andrew Jones
2023-10-11 13:56 ` [PATCH v1 6/6] RISC-V: selftests: Add which-cpus hwprobe test Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231012-riverbed-surprise-d5aa8adb6110@spud \
    --to=conor@kernel.org \
    --cc=ajones@ventanamicro.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=apatel@ventanamicro.com \
    --cc=conor.dooley@microchip.com \
    --cc=evan@rivosinc.com \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=palmer@rivosinc.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox