From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0ABD7C4167B for ; Tue, 28 Nov 2023 14:52:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0iXe5bFmiVfQKZnXxBsDkWcvzNa1xoa9v/r2JSNKBk4=; b=TOoDkS8oD7C1dY chOST1cv5noL7NkAQgC5m44QcCQMRHiCshKTgZrs2MLc58f+dPcXBJNfdUPhCgHQ3tdVrYXIPZZCG EenOhR3T1T+FOYyl6l6KNEtjEDnpz9HcJg/gWlKsyG81C/K+VvtZYAJeOP6XW7coowBIMXh+2R1c6 +psyAULiIPPoXGZ8v7g7ur96owqlmn1CDYRP0mI5rZaF1bead/29j5fDmHUQm9BqoQXzKqHMB+GpQ AGzJYVXrtcv9Qv68MpfLxt8nHeCJHV7eigwaX99781vVEnFZNIiYGqCsMWQMgU4kCKb0XoJAJ2Rlz Z8/AoqD26t2bhT7ESA/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7zRR-005YiQ-0R; Tue, 28 Nov 2023 14:52:01 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r7zRN-005YhC-0O; Tue, 28 Nov 2023 14:51:58 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Sflk36nr0z6K9B5; Tue, 28 Nov 2023 22:50:19 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 8A048140D1D; Tue, 28 Nov 2023 22:51:53 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 28 Nov 2023 14:51:52 +0000 Date: Tue, 28 Nov 2023 14:51:52 +0000 From: Jonathan Cameron To: "Russell King (Oracle)" CC: , , , , , , , , , , , , , Salil Mehta , Jean-Philippe Brucker , , , James Morse , Greg Kroah-Hartman , "Rafael J. Wysocki" , Paul Walmsley , "Palmer Dabbelt" , Albert Ou Subject: Re: [PATCH RFC 08/22] drivers: base: Implement weak arch_unregister_cpu() Message-ID: <20231128145152.00003ce7@Huawei.com> In-Reply-To: References: Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231128_065157_300014_D039841C X-CRM114-Status: GOOD ( 13.04 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org > > + > > +#ifdef CONFIG_HOTPLUG_CPU > > +void __weak arch_unregister_cpu(int num) > > +{ > > + unregister_cpu(&per_cpu(cpu_devices, num)); > > +} > > +#endif /* CONFIG_HOTPLUG_CPU */ > > I have previously asked the question whether we should provide a > stub weak function for the !HOTPLUG_CPU case for this, which would > alleviate the concerns around if (IS_ENABLED()) in some of the later > hotplug vCPU patches... which failed to get _any_ responses. > > So, I'm now going to deem the comment I received about if (IS_ENABLED()) > potentially causing issues to be unimportant, and thus there's no > need for a stub weak function. If we start getting compile errors, > then we can address the issue at that point. So far, however, the > kernel build bot has not identified that this as an issue... and it's > been chewing on this entire patch set for well over a month now. > Make sense to fix this only if it's a real problem. Reviewed-by: Jonathan Cameron _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv