From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAC62C4167B for ; Wed, 29 Nov 2023 06:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID:References: Mime-Version:In-Reply-To:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UEXr3hRC8Km+3BIrPI4zROAoGaO4FbnF+8C4QLy3650=; b=12WxzRSRnNdlyv Ap80nrTkAHfGVRlf/yzaJAKFzW9dSabUn83TGQ621YYD+6npNdMDUprC8GL5BHtAMS+GQl701Zd5V UQsscyNMdTk9sl2TX6w6bB7pqLma+uo/tIZINkW3XXuZkSlOrQEimqreTYKqsvJzkaNo8zXMpUrvk QOpXg87dnCdE/aBrKv1FsqXTPLK6Wvp/j2FWAD+otM4VZ2MGAD+1Sn88E6zyg/HOQ3p8e1pCK6310 r+oqGt1WK5mn0gQmMzRMvb0seYpqS6xaRsPoCRV+NtYdDbmqHgNGaJYp2+wolSvOtz8AKEYlhLTR3 Tl/twrKTwIi01Ct0WFFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8Di7-007BDz-35; Wed, 29 Nov 2023 06:06:11 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8Di5-007BBX-18 for linux-riscv@lists.infradead.org; Wed, 29 Nov 2023 06:06:10 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-5cd6a86a898so78490557b3.3 for ; Tue, 28 Nov 2023 22:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701237965; x=1701842765; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=BFBgGZHgdrEFpnu/cpKOcJzser1reIBdXzg/6fniV64=; b=TbwqyZtgeDzUrxgq8BQX+grkf8Js4e0FKeeFrvAZJqHVReB4NJi0PV7/0HrCYKWcEV ChsfaOJcYJz9eo8rx37T7Nzi6FpJVD+NSU3BDLRpwSaOdXzdxWNO07J+zuGrmsAo7JxP hn2zQ4Oy4Z0J+DZ8JcRs3HTz5e1cyYmqukW1EFRqJ7YES9WhLT5LUW1+4vp+5io3JNO6 vLzMSUzAuH+nNMbmJMOA3wB9qFN6D8fGeRz5yr1/aPkYVMFREg0KLwkDeA5wzzeis2vd 4WaQ2EKMfOSSq91847+rAHzQ6Tt5D4Scmc0Lo5ctclqaDPT+rAMy2XW1Nztt2fetA6Nz qhJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701237965; x=1701842765; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BFBgGZHgdrEFpnu/cpKOcJzser1reIBdXzg/6fniV64=; b=Z7xGvRQ5ug2eYnnX3xtkt5a/sbdgzk0s9m/ia4yyNzfaEAxrNo/iwgld09TCaQiOJq aWzVb4kEe2WdYNFdRQ3qaJP6HZAjMh3nDkW5pSGKJUEkhNobbuDTbEFsiEUykLBZ+khb qUribSbQQ28ZY6ky96q7zrZwGceOXk8LbXgeVePw6IxqUO4Zze0FEFYOzao/kiWddI6I 3ICXz7dE9AM9I+l5Vq+u0q9EbveDMslJ5kGDBVIuDKcooVcmcyehPMKeVEGJyl+ErNNk 0O6+JxaEHZ4AaqHB09neCK4pjgXzvDj8y9Nee0m24eDgUZo5g2+1eV2JHoBG8l+LrDhj UzlQ== X-Gm-Message-State: AOJu0Yx/itv0AKiJOjWWHyQtYd6KtiSVhN4HUo8DCFpLtigaoKKL5CkH 0tiiehvGfwSCFclGVJxCi48SSynJeGHm X-Google-Smtp-Source: AGHT+IG4ZcbE3hB8V6+vKX0zxYUr0OpHfbf/WNlvcGBdlOoo8eTYBCxtpp+7m/8KdVPZTHDTWhORx94znMfW X-Received: from morats.c.googlers.com ([fda3:e722:ac3:cc00:14:4d90:c0a8:d9e]) (user=moritzf job=sendgmr) by 2002:a25:c044:0:b0:db5:1f69:704e with SMTP id c65-20020a25c044000000b00db51f69704emr38263ybf.1.1701237964651; Tue, 28 Nov 2023 22:06:04 -0800 (PST) Date: Wed, 29 Nov 2023 06:06:03 +0000 In-Reply-To: <4-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com> Mime-Version: 1.0 References: <0-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com> <4-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com> Message-ID: <20231129060603.hxtmbsefxurxnwkh@google.com> Subject: Re: [PATCH 04/10] iommu: Mark dev_iommu_get() with lockdep From: Moritz Fischer To: Jason Gunthorpe Cc: David Airlie , Alyssa Rosenzweig , Albert Ou , asahi@lists.linux.dev, Catalin Marinas , Danilo Krummrich , Daniel Vetter , Dexuan Cui , devicetree@vger.kernel.org, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, David Woodhouse , Frank Rowand , Hanjun Guo , Haiyang Zhang , iommu@lists.linux.dev, Jon Hunter , Joerg Roedel , Karol Herbst , Krzysztof Kozlowski , "K. Y. Srinivasan" , Laxman Dewangan , Len Brown , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-snps-arc@lists.infradead.org, linux-tegra@vger.kernel.org, Russell King , Lorenzo Pieralisi , Lyude Paul , Marek Szyprowski , nouveau@lists.freedesktop.org, Palmer Dabbelt , Paul Walmsley , "Rafael J. Wysocki" , Rob Herring , Robin Murphy , Sudeep Holla , Suravee Suthikulpanit , Sven Peter , Thomas Bogendoerfer , Vineet Gupta , Vinod Koul , Wei Liu , Will Deacon , Lu Baolu , Christoph Hellwig , Jerry Snitselaar , Hector Martin , Moritz Fischer , patches@lists.linux.dev, "Rafael J. Wysocki" , Rob Herring , Thierry Reding X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231128_220609_784507_D26D219B X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed"; DelSp="yes" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Nov 28, 2023 at 08:48:00PM -0400, Jason Gunthorpe wrote: > Allocation of dev->iommu must be done under the > iommu_probe_device_lock. Mark this with lockdep to discourage future > mistakes. > Reviewed-by: Jerry Snitselaar > Tested-by: Hector Martin > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/iommu.c | 2 ++ > 1 file changed, 2 insertions(+) > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 0d25468d53a68a..4323b6276e977f 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -334,6 +334,8 @@ static struct dev_iommu *dev_iommu_get(struct device > *dev) > { > struct dev_iommu *param = dev->iommu; > + lockdep_assert_held(&iommu_probe_device_lock); > + > if (param) > return param; > -- > 2.42.0 Reviewed-by: Moritz Fischer Cheers, Moritz _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv