From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6F9DC4167B for ; Wed, 29 Nov 2023 06:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID:References: Mime-Version:In-Reply-To:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ri6knp19PfbdElb5qnCiEddWQv2eutVIhK3PiedK1fg=; b=qj80pLJnmtIKZa AOz5M0p7J8ZiKav0FDv/q3hOu2jnBxedOU617i/UEAw6TxNvgUIghK7EfCEXsh9v11q4zIFaTd/v5 IXcQb+IFIzqO1tBWqwVtG33Xthy/gu90sBN82J2dB7qvE3X8SY10lz7vX79lXbWgV6seLCs6ZZc0i mGctUUWOUbw2qDDlvHthzvCQS5Ztq6Ag0m66BBGnw4OdqBd9fpL4OQ3R4PqpSq8bfYugBucmQWrUf fv9g/1TN3r2/K+iAlnvuX3Wri7zb9nyf8UXFxMyoQqfNd7jpPei1z/669utP44GvxUSrAMVl/nl4v Y78v9h7bbgkocYmbp6hQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8Du4-007CXu-1I; Wed, 29 Nov 2023 06:18:32 +0000 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8Du0-007CV9-1r for linux-riscv@lists.infradead.org; Wed, 29 Nov 2023 06:18:29 +0000 Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-db402e6f61dso7437436276.3 for ; Tue, 28 Nov 2023 22:18:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701238707; x=1701843507; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=8J4qMZXxn7dMNLyiBgKsZSJFUlenzauaBGTwqmqEkBs=; b=p5IYh5/meUWdrf1OHd6tub5A6iJ+wvBYKR+vJ129N/RUeBSmKvfdUDRj1PcX518/Eg ABqWKCirOKqhAZG+EZW5N/1eXxPNZIHx7VbYYny7ufVCZ4viqZlOT99RqCPuxnkscJxE XdHewNLzh+VRmul6NWGt24JGe2wBjuVzvIrnEG02fWr6VIQ/U8zO7BePdycd/ZT7awhw 13uoPh3d0mVGrnQYJXJwkSUo7Nb30mzrljkGlwlwg4H7XvznHiklfCRD4knZ1FCoLjjz r213qPYeQNPsV6hz1TXuWv6alxX4mAY77VJeXDbjVTWEnj4mXZi9MRJ+6ncYThan2/KV Bfeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701238707; x=1701843507; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8J4qMZXxn7dMNLyiBgKsZSJFUlenzauaBGTwqmqEkBs=; b=HWH6DJ3ZwbvHelCAjueqA8vnmUg5u7wuF6Zu2h83ZCkaeZ3v/7kGnWN/0jsLv7hsKr N0WB4shCeMVmonjh59dZR3LPlCo22myRnFRoDqVm3BGiE88V4Hxhm5uK1u4ajNrwDzAz rSlapFdhCdDImmG0EGPQ1WueXk7dLcaAyoyktLfuOkUkeCIlw6Sq6mLPIdRX9W9h/rOo zEjGW3iQOiNjhJKi+ysXle7s8d8AqU0nP47QyOGIMwtGIVtSc+ovYXf11IGH/+r6CbBj fcxWHKAyVlOyosggIW8O5kFvxgHnU7lxeeo5X8mpRDz+djQrhBBjTHkNHOOK/uSSW8Ta 5Qlg== X-Gm-Message-State: AOJu0YxxCZiCapnQXa9hri6QHoHDNa88n25NMGD+GMvzsV7H3yqUelKH wso+WXkDzh1nWSUzEijPC40bzRBhtWHP X-Google-Smtp-Source: AGHT+IFcUygGdfS95PQxvEDzLlpossLvNyVov+P9EiIyJqoPwhfNYT1rdzAgRP7ca8iJPDCSOmBZ7cELCldp X-Received: from morats.c.googlers.com ([fda3:e722:ac3:cc00:14:4d90:c0a8:d9e]) (user=moritzf job=sendgmr) by 2002:a25:d287:0:b0:db3:8b00:22eb with SMTP id j129-20020a25d287000000b00db38b0022ebmr482941ybg.6.1701238706756; Tue, 28 Nov 2023 22:18:26 -0800 (PST) Date: Wed, 29 Nov 2023 06:18:25 +0000 In-Reply-To: <9-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com> Mime-Version: 1.0 References: <0-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com> <9-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com> Message-ID: <20231129061825.altvhmgltws2bvhh@google.com> Subject: Re: [PATCH 09/10] ACPI: IORT: Cast from ULL to phys_addr_t From: Moritz Fischer To: Jason Gunthorpe Cc: David Airlie , Alyssa Rosenzweig , Albert Ou , asahi@lists.linux.dev, Catalin Marinas , Danilo Krummrich , Daniel Vetter , Dexuan Cui , devicetree@vger.kernel.org, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, David Woodhouse , Frank Rowand , Hanjun Guo , Haiyang Zhang , iommu@lists.linux.dev, Jon Hunter , Joerg Roedel , Karol Herbst , Krzysztof Kozlowski , "K. Y. Srinivasan" , Laxman Dewangan , Len Brown , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-snps-arc@lists.infradead.org, linux-tegra@vger.kernel.org, Russell King , Lorenzo Pieralisi , Lyude Paul , Marek Szyprowski , nouveau@lists.freedesktop.org, Palmer Dabbelt , Paul Walmsley , "Rafael J. Wysocki" , Rob Herring , Robin Murphy , Sudeep Holla , Suravee Suthikulpanit , Sven Peter , Thomas Bogendoerfer , Vineet Gupta , Vinod Koul , Wei Liu , Will Deacon , Lu Baolu , Christoph Hellwig , Jerry Snitselaar , Hector Martin , Moritz Fischer , patches@lists.linux.dev, "Rafael J. Wysocki" , Rob Herring , Thierry Reding X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231128_221828_617277_6EF4A333 X-CRM114-Status: GOOD ( 16.12 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed"; DelSp="yes" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Nov 28, 2023 at 08:48:05PM -0400, Jason Gunthorpe wrote: > gcc on i386 (when compile testing) warns: This is a weird test. The Makefile for drivers/acpi/arm64 is conditional on CONFIG_ARM64. How does this happen? > 8->8 obj-$(CONFIG_ARM64) += arm64/ > 8->8 > drivers/acpi/arm64/iort.c:2014:18: warning: implicit conversion > from 'unsigned long long' to 'phys_addr_t' (aka 'unsigned int') changes > value from 18446744073709551615 to 4294967295 [-Wconstant-conversion] > local_limit = > DMA_BIT_MASK(ncomp->memory_address_limit); > Because DMA_BIT_MASK returns a large ULL constant. Explicitly truncate it > to phys_addr_t. > Signed-off-by: Jason Gunthorpe > --- > drivers/acpi/arm64/iort.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index 6496ff5a6ba20d..bdaf9256870d92 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -2011,7 +2011,8 @@ phys_addr_t __init > acpi_iort_dma_get_max_cpu_address(void) > case ACPI_IORT_NODE_NAMED_COMPONENT: > ncomp = (struct acpi_iort_named_component *)node->node_data; > - local_limit = DMA_BIT_MASK(ncomp->memory_address_limit); > + local_limit = (phys_addr_t)DMA_BIT_MASK( > + ncomp->memory_address_limit); > limit = min_not_zero(limit, local_limit); > break; > @@ -2020,7 +2021,8 @@ phys_addr_t __init > acpi_iort_dma_get_max_cpu_address(void) > break; > rc = (struct acpi_iort_root_complex *)node->node_data; > - local_limit = DMA_BIT_MASK(rc->memory_address_limit); > + local_limit = (phys_addr_t)DMA_BIT_MASK( > + rc->memory_address_limit); > limit = min_not_zero(limit, local_limit); > break; > } > -- > 2.42.0 Cheers, Moritz _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv