Re: [PATCH v1 03/14] RISC-V: paravirt: Implement steal-time support

Conor Dooley
2023-12-07T14:07:27Z

[-- Attachment #1.1: Type: text/plain, Size: 638 bytes --]

On Tue, Dec 05, 2023 at 07:11:23PM +0100, Andrew Jones wrote:

> +static int sbi_sta_steal_time_set_shmem(unsigned long lo, unsigned long hi,
> + unsigned long flags)
> {
> + struct sbiret ret;
> +
> + ret = sbi_ecall(SBI_EXT_STA, SBI_EXT_STA_STEAL_TIME_SET_SHMEM,
> + lo, hi, flags, 0, 0, 0);
> + if (ret.error) {
> + if (lo == SBI_STA_SHMEM_DISABLE && hi == SBI_STA_SHMEM_DISABLE)
> + pr_warn("Failed to disable steal-time shmem");
> + else
> + pr_warn("Failed to set steal-time shmem");
> + return -ENOMEM;

btw, how come this is an ENOMEM and not a propagation of the error from
the ecall?

> + }
> +
> return 0;
> }

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]