[PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE

[PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE

[Jia Jie Ho]

Selects ARM_AMBA platform support for StarFive SoCs required by spi and
crypto dma engine.

Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
---
 arch/riscv/Kconfig.socs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
index 1cf69f958f10..381cd46e6373 100644
--- a/arch/riscv/Kconfig.socs
+++ b/arch/riscv/Kconfig.socs
@@ -29,6 +29,7 @@ config SOC_STARFIVE
 	bool "StarFive SoCs"
 	select PINCTRL
 	select RESET_CONTROLLER
+	select ARM_AMBA
 	help
 	  This enables support for StarFive SoC platform hardware.
 
-- 
2.25.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE

[Conor Dooley]

[-- Attachment #1.1: Type: text/plain, Size: 910 bytes --]

On Thu, May 25, 2023 at 02:18:36PM +0800, Jia Jie Ho wrote:
> Selects ARM_AMBA platform support for StarFive SoCs required by spi and
> crypto dma engine.

Thanks for sending this.
@Palmer, this depends on another commit not to introduce a build
breakage. I'll assign it to myself on patchwork and grab it when it is
okay to take.

Cheers,
Conor.

> Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> ---
>  arch/riscv/Kconfig.socs | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index 1cf69f958f10..381cd46e6373 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -29,6 +29,7 @@ config SOC_STARFIVE
>  	bool "StarFive SoCs"
>  	select PINCTRL
>  	select RESET_CONTROLLER
> +	select ARM_AMBA
>  	help
>  	  This enables support for StarFive SoC platform hardware.
>  
> -- 
> 2.25.1
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE

[Palmer Dabbelt]

On Wed, 24 May 2023 23:23:12 PDT (-0700), Conor Dooley wrote:
> On Thu, May 25, 2023 at 02:18:36PM +0800, Jia Jie Ho wrote:
>> Selects ARM_AMBA platform support for StarFive SoCs required by spi and
>> crypto dma engine.
>
> Thanks for sending this.
> @Palmer, this depends on another commit not to introduce a build
> breakage. I'll assign it to myself on patchwork and grab it when it is
> okay to take.
>
> Cheers,
> Conor.
>
>> Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
>> ---
>>  arch/riscv/Kconfig.socs | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
>> index 1cf69f958f10..381cd46e6373 100644
>> --- a/arch/riscv/Kconfig.socs
>> +++ b/arch/riscv/Kconfig.socs
>> @@ -29,6 +29,7 @@ config SOC_STARFIVE
>>  	bool "StarFive SoCs"
>>  	select PINCTRL
>>  	select RESET_CONTROLLER
>> +	select ARM_AMBA
>>  	help
>>  	  This enables support for StarFive SoC platform hardware.
>>  
>> -- 
>> 2.25.1
>> 

Acked-by: Palmer Dabbelt <palmer@rivosinc.com>

Thanks!

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE

[Conor Dooley]

From: Conor Dooley <conor.dooley@microchip.com>

On Thu, 25 May 2023 14:18:36 +0800, Jia Jie Ho wrote:
> Selects ARM_AMBA platform support for StarFive SoCs required by spi and
> crypto dma engine.
> 
> 

Applied to riscv-soc-for-next, thanks!

[1/1] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE
      https://git.kernel.org/conor/c/1fcaaa1d489c

Thanks,
Conor.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE

[Nam Cao]

On Sun, Jul 09, 2023 at 11:10:47PM +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> On Thu, 25 May 2023 14:18:36 +0800, Jia Jie Ho wrote:
> > Selects ARM_AMBA platform support for StarFive SoCs required by spi and
> > crypto dma engine.
> > 
> > 
> 
> Applied to riscv-soc-for-next, thanks!
> 
> [1/1] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE
>       https://git.kernel.org/conor/c/1fcaaa1d489c
> 
> Thanks,
> Conor.

Sorry if it's a stupid question, but did this patch get lost somehow? It
hasn't made it to Linus's tree, and there is this message in your tree:
"Notice: this object is not reachable from any branch."

Best regards,
Nam

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE

[Conor Dooley]

[-- Attachment #1.1: Type: text/plain, Size: 1020 bytes --]

On Mon, Oct 16, 2023 at 03:26:13PM +0200, Nam Cao wrote:
> On Sun, Jul 09, 2023 at 11:10:47PM +0100, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> > 
> > On Thu, 25 May 2023 14:18:36 +0800, Jia Jie Ho wrote:
> > > Selects ARM_AMBA platform support for StarFive SoCs required by spi and
> > > crypto dma engine.
> > > 
> > > 
> > 
> > Applied to riscv-soc-for-next, thanks!
> > 
> > [1/1] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE
> >       https://git.kernel.org/conor/c/1fcaaa1d489c
> > 
> > Thanks,
> > Conor.
> 
> Sorry if it's a stupid question, but did this patch get lost somehow? It
> hasn't made it to Linus's tree, and there is this message in your tree:
> "Notice: this object is not reachable from any branch."

No, it is not a stupid question sadly. I screwed up and forgot to send a
PR for that branch to Arnd, only realising _after_ the merge window had
closed already. It'll be in 6.7, the branch got rebased so the hash is
no longer valid.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE

[Nam Cao]

On Thu, May 25, 2023 at 02:18:36PM +0800, Jia Jie Ho wrote:
> Selects ARM_AMBA platform support for StarFive SoCs required by spi and
> crypto dma engine.
> 
> Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> ---
>  arch/riscv/Kconfig.socs | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index 1cf69f958f10..381cd46e6373 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -29,6 +29,7 @@ config SOC_STARFIVE
>  	bool "StarFive SoCs"
>  	select PINCTRL
>  	select RESET_CONTROLLER
> +	select ARM_AMBA
>  	help
>  	  This enables support for StarFive SoC platform hardware.

I'm considering sending this to stable trees. Without this, it is not
possible to configure the kernel with SPI driver for the starfive board.

I just want to check with you first, in case I miss something obvious.
Any objection to backporting this patch?

Best regards,
Nam

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE

[Conor Dooley]

[-- Attachment #1.1: Type: text/plain, Size: 1388 bytes --]

On Tue, Nov 28, 2023 at 11:27:22AM +0100, Nam Cao wrote:
> On Thu, May 25, 2023 at 02:18:36PM +0800, Jia Jie Ho wrote:
> > Selects ARM_AMBA platform support for StarFive SoCs required by spi and
> > crypto dma engine.
> > 
> > Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> > ---
> >  arch/riscv/Kconfig.socs | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> > index 1cf69f958f10..381cd46e6373 100644
> > --- a/arch/riscv/Kconfig.socs
> > +++ b/arch/riscv/Kconfig.socs
> > @@ -29,6 +29,7 @@ config SOC_STARFIVE
> >  	bool "StarFive SoCs"
> >  	select PINCTRL
> >  	select RESET_CONTROLLER
> > +	select ARM_AMBA
> >  	help
> >  	  This enables support for StarFive SoC platform hardware.
> 
> I'm considering sending this to stable trees. Without this, it is not
> possible to configure the kernel with SPI driver for the starfive board.
> 
> I just want to check with you first, in case I miss something obvious.
> Any objection to backporting this patch?

Personally I would be okay with that, otherwise the driver is dead code
in those stable versions. Just be sure that the rename of some pl011
variables (I think that's what it was) that was a pre-req for this being
merged is in said versions of stable. An allmodconfig should flag
whether that has happened pretty quickly.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE

[Nam Cao]

On Tue, 28 Nov 2023 10:59:44 +0000 Conor Dooley <conor.dooley@microchip.com> wrote:
> On Tue, Nov 28, 2023 at 11:27:22AM +0100, Nam Cao wrote:
> > On Thu, May 25, 2023 at 02:18:36PM +0800, Jia Jie Ho wrote:  
> > > Selects ARM_AMBA platform support for StarFive SoCs required by spi and
> > > crypto dma engine.
> > > 
> > > Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> > > ---
> > >  arch/riscv/Kconfig.socs | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> > > index 1cf69f958f10..381cd46e6373 100644
> > > --- a/arch/riscv/Kconfig.socs
> > > +++ b/arch/riscv/Kconfig.socs
> > > @@ -29,6 +29,7 @@ config SOC_STARFIVE
> > >  	bool "StarFive SoCs"
> > >  	select PINCTRL
> > >  	select RESET_CONTROLLER
> > > +	select ARM_AMBA
> > >  	help
> > >  	  This enables support for StarFive SoC platform hardware.  
> > 
> > I'm considering sending this to stable trees. Without this, it is not
> > possible to configure the kernel with SPI driver for the starfive board.
> > 
> > I just want to check with you first, in case I miss something obvious.
> > Any objection to backporting this patch?  
> 
> Personally I would be okay with that, otherwise the driver is dead code
> in those stable versions. Just be sure that the rename of some pl011
> variables (I think that's what it was) that was a pre-req for this being
> merged is in said versions of stable. An allmodconfig should flag
> whether that has happened pretty quickly.

Thanks for the info. I think I found what you are talking about:
a1a5f2c88725 ("dmaengine: pl330: rename _start to prevent build error")

It's been a while and no one else said anything, so I am going forward with
this.

Best regards,
Nam


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE

[Conor Dooley]

[-- Attachment #1.1: Type: text/plain, Size: 1974 bytes --]

On Mon, Dec 11, 2023 at 02:36:11PM +0100, Nam Cao wrote:
> On Tue, 28 Nov 2023 10:59:44 +0000 Conor Dooley <conor.dooley@microchip.com> wrote:
> > On Tue, Nov 28, 2023 at 11:27:22AM +0100, Nam Cao wrote:
> > > On Thu, May 25, 2023 at 02:18:36PM +0800, Jia Jie Ho wrote:  
> > > > Selects ARM_AMBA platform support for StarFive SoCs required by spi and
> > > > crypto dma engine.
> > > > 
> > > > Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> > > > ---
> > > >  arch/riscv/Kconfig.socs | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> > > > index 1cf69f958f10..381cd46e6373 100644
> > > > --- a/arch/riscv/Kconfig.socs
> > > > +++ b/arch/riscv/Kconfig.socs
> > > > @@ -29,6 +29,7 @@ config SOC_STARFIVE
> > > >  	bool "StarFive SoCs"
> > > >  	select PINCTRL
> > > >  	select RESET_CONTROLLER
> > > > +	select ARM_AMBA
> > > >  	help
> > > >  	  This enables support for StarFive SoC platform hardware.  
> > > 
> > > I'm considering sending this to stable trees. Without this, it is not
> > > possible to configure the kernel with SPI driver for the starfive board.
> > > 
> > > I just want to check with you first, in case I miss something obvious.
> > > Any objection to backporting this patch?  
> > 
> > Personally I would be okay with that, otherwise the driver is dead code
> > in those stable versions. Just be sure that the rename of some pl011
> > variables (I think that's what it was) that was a pre-req for this being
> > merged is in said versions of stable. An allmodconfig should flag
> > whether that has happened pretty quickly.
> 
> Thanks for the info. I think I found what you are talking about:
> a1a5f2c88725 ("dmaengine: pl330: rename _start to prevent build error")
> 
> It's been a while and no one else said anything, so I am going forward with
> this.

Yeah, that's the one. Sorry that I did not recall correctly.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv