From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DE3BC4332F for ; Wed, 13 Dec 2023 13:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FKGxmSf8uZ0a5aD5dDJXFrbpPKtpOebiWex8RGYH0zc=; b=ZpHaI6JyYbgB9Ca0UXvCe+UUv+ KVyUojKtgy6GQWsT5CGDFsBjQiDNHduY/hlVQA16si9WVJlbYOQVT+IKTNH9aEBuEvk3+R4m2b/Ev 0BkP9BHaCdPIaSFbE+ktmTCmQ/8c6lv2uCWXzNQi3SDeXJlAEl8+fk4aIjjFNgqUv4eCDib1j1GpA hc4XbBh4dZo9VizOWQECiRGVTnRpaVCu55dnxZLgpu86PMMB9qV0khRAdplpcQfhjBKT0OtKtb6c8 +5MbUUncICiaUhTr2q2ior4Y3UxpHyQh5kti1sxrzc4sAk/sYywKSvK4eIdV3Kibr7VQkn6b1Dkfl OH5rB7NQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDOtA-00Ej8v-12; Wed, 13 Dec 2023 13:03:00 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDOt7-00Ej80-2I for linux-riscv@lists.infradead.org; Wed, 13 Dec 2023 13:02:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 59B8EB81CCC; Wed, 13 Dec 2023 13:02:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B73FFC433C8; Wed, 13 Dec 2023 13:02:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702472575; bh=SYhlR91tO42bA8AfGZXjJpENUJXvfJwI9ZrVd2yDl7o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pOAZ793fHzKh/HYPbFWxrP57xdIvDGz7zJAPafMIdiXo/gdClWfHHvXyABgyiaI3d IzjD7flCvOmUtRPQK/nwxFG4P+/wjewBRhds66wynKr/e/B9HcmsYwbGWOiDfrcGgF Mad+vti/3CHqhV9Mc8DmDCiHi5Llrhj8bBvRK8yG2/BfMYB5kldfx6AoNVi3LS5Yed voYZzMviyN03AtFIwzndO9A1hh6wyeIOadgNlhvE3YVLQFoRmcz/zTpvLmVk2qGecJ c2p65kbrZ/i6niLm0i+F8ERk9GXSfIiwFL6+xEZru50pieVHqYJCoculVkT2y+ID+D uMM7/fLCxbELQ== Date: Wed, 13 Dec 2023 13:02:49 +0000 From: Conor Dooley To: Marc Kleine-Budde Cc: linux-riscv@lists.infradead.org, Conor Dooley , Daire McNamara , Wolfgang Grandegger , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Michael Turquette , Stephen Boyd , linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH RESEND v1 2/7] dt-bindings: can: mpfs: add missing required clock Message-ID: <20231213-waffle-grueling-3a5c3879395b@spud> References: <20231208-reenter-ajar-b6223e5134b3@spud> <20231208-palpitate-passable-c79bacf2036c@spud> <20231212-unreeling-depose-8b6b2e032555-mkl@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20231212-unreeling-depose-8b6b2e032555-mkl@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_050258_028601_D00FBEC4 X-CRM114-Status: GOOD ( 20.71 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8987092822921972911==" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org --===============8987092822921972911== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AuzXFLC6CIKr68l9" Content-Disposition: inline --AuzXFLC6CIKr68l9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 12, 2023 at 09:49:41PM +0100, Marc Kleine-Budde wrote: > On 08.12.2023 17:12:24, Conor Dooley wrote: > > From: Conor Dooley > >=20 > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > > CAN bus clock. The bus clock was omitted when the binding was written, > > but is required for operation. Make up for lost time and add it. > >=20 > > Cautionary tale in adding bindings without having implemented a real > > user for them perhaps. > >=20 > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN con= troller") > > Signed-off-by: Conor Dooley > > --- > > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-c= an.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > index 45aa3de7cf01..05f680f15b17 100644 > > --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml > > @@ -24,7 +24,10 @@ properties: > > maxItems: 1 > > =20 > > clocks: > > - maxItems: 1 > > + maxItems: 2 > > + items: > > + - description: AHB peripheral clock > > + - description: CAN bus clock >=20 > Do we we want to have a "clock-names" property, as we need the clock > rate of the CAN bus clock. We should not need the clock-names property to be able to get both of the clocks. clk_bulk_get_all() for example should be usable here. Cheers, Conor. --AuzXFLC6CIKr68l9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZXmreQAKCRB4tDGHoIJi 0pybAQCaXK2xUCp5W6797bY/KOydLDfzz6/zpgo3/ym1K/7tCgEAs+ZQmqrTvSuQ t2sr42Cf8RWYaRCGrwl6zg97g0jV0As= =jW/W -----END PGP SIGNATURE----- --AuzXFLC6CIKr68l9-- --===============8987092822921972911== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv --===============8987092822921972911==--