From: Andre Przywara <andre.przywara@arm.com>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Yangtao Li <tiny.windzz@gmail.com>,
Brandon Cheo Fusi <fusibrandon13@gmail.com>,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/5] cpufreq: sun50i: Add D1 support
Date: Thu, 14 Dec 2023 16:40:10 +0000 [thread overview]
Message-ID: <20231214164010.0be50a89@donnerap.manchester.arm.com> (raw)
In-Reply-To: <8351928.NyiUUSuA9g@archlinux>
On Thu, 14 Dec 2023 17:29:30 +0100
Jernej Škrabec <jernej.skrabec@gmail.com> wrote:
Hi,
> On Thursday, December 14, 2023 11:33:39 AM CET Brandon Cheo Fusi wrote:
> > Add support for D1 based devices to the Allwinner H6 cpufreq
> > driver
> >
> > Signed-off-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
> > ---
> > drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> > index 32a9c88f8..ccf83780f 100644
> > --- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> > +++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> > @@ -160,6 +160,7 @@ static struct platform_driver sun50i_cpufreq_driver = {
> >
> > static const struct of_device_id sun50i_cpufreq_match_list[] = {
> > { .compatible = "allwinner,sun50i-h6" },
> > + { .compatible = "allwinner,sun20i-d1" },
>
> This is not needed, as there is no functionality change.
That was my first reflex, too, but this is the *board* (fallback)
compatible, listed in the root node, so you have to list it here for each
SoC, together with the respective blocklist in the next patch.
We are doing the same for the H616, and actually also need that for the
H618. Weird, I know, but last time I check not easy to fix.
Cheers,
Andre
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-12-14 16:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 10:33 [PATCH 0/5] cpufreq support for the D1 Brandon Cheo Fusi
2023-12-14 10:33 ` [PATCH 1/5] riscv: dts: allwinner: Update opp table to allow CPU frequency scaling Brandon Cheo Fusi
2023-12-14 11:14 ` Viresh Kumar
2023-12-14 13:47 ` Conor Dooley
2023-12-14 16:36 ` Jernej Škrabec
2023-12-15 15:18 ` Brandon Cheo Fusi
2023-12-15 15:12 ` Brandon Cheo Fusi
2023-12-14 10:33 ` [PATCH 2/5] cpufreq: sun50i: Add D1 support Brandon Cheo Fusi
2023-12-14 16:29 ` Jernej Škrabec
2023-12-14 16:40 ` Andre Przywara [this message]
2023-12-14 17:15 ` Jernej Škrabec
2023-12-14 10:33 ` [PATCH 3/5] cpufreq: dt-platdev: Blocklist allwinner,sun20i-d1 SoC Brandon Cheo Fusi
2023-12-14 16:30 ` Jernej Škrabec
2023-12-14 10:33 ` [PATCH 4/5] cpufreq: Add support for RISC-V CPU Frequency scaling drivers Brandon Cheo Fusi
2023-12-14 11:17 ` Viresh Kumar
2023-12-15 15:17 ` Brandon Cheo Fusi
2023-12-15 21:09 ` Samuel Holland
2023-12-18 6:09 ` Viresh Kumar
2023-12-14 10:33 ` [PATCH 5/5] cpufreq: Make sun50i h6 cpufreq Kconfig option generic Brandon Cheo Fusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214164010.0be50a89@donnerap.manchester.arm.com \
--to=andre.przywara@arm.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fusibrandon13@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=tiny.windzz@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).