Re: [PATCH] RISC-V: Update AT_VECTOR_SIZE_ARCH for new AT_MINSIGSTKSZ

From: Conor Dooley <conor@kernel.org>
To: Victor Isaev <victor@torrio.net>
Cc: linux-riscv@lists.infradead.org
Subject: Re: [PATCH] RISC-V: Update AT_VECTOR_SIZE_ARCH for new AT_MINSIGSTKSZ
Date: Sat, 16 Dec 2023 11:45:33 +0000	[thread overview]
Message-ID: <20231216-proofread-headed-08642dda8684@spud> (raw)
In-Reply-To: <73883406.20231215232720@torrio.net>

[-- Attachment #1.1: Type: text/plain, Size: 2093 bytes --]

Hey,

A few process issues here unfortunately.

On Fri, Dec 15, 2023 at 11:27:20PM -0500, Victor Isaev wrote:
> "riscv: signal: Report signal frame size to userspace via auxv" (e92f469)
> has added new constant AT_MINSIGSTKSZ but failed to increment the size of
> auxv, keeping AT_VECTOR_SIZE_ARCH at 9.
> This fix correctly increments AT_VECTOR_SIZE_ARCH to 10, following the 
> approach in the commit 94b07c1 ("arm64: signal: Report signal frame size
> to userspace via auxv").

Both of your references to commits do not use the correct style, that
checkpatch would have told you about:
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 94b07c1f8c39 ("arm64: signal: Report signal frame size to userspace via auxv")'
#97: 
approach in the commit 94b07c1 ("arm64: signal: Report signal frame size
to userspace via auxv").

Also, you should add a Fixes: tag for the first commit you mention here
since it is the source of the bug.

> ---
>  a/arch/riscv/include/uapi/asm/auxvec.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/include/uapi/asm/auxvec.h b/arch/riscv/include/uapi/asm/auxvec.h
> index 10aaa83db89e..95050ebe9ad0 100644
> --- a/arch/riscv/include/uapi/asm/auxvec.h
> +++ b/arch/riscv/include/uapi/asm/auxvec.h
> @@ -34,7 +34,7 @@
>  #define AT_L3_CACHEGEOMETRY    47
> 
>  /* entries in ARCH_DLINFO */
> -#define AT_VECTOR_SIZE_ARCH    9
> +#define AT_VECTOR_SIZE_ARCH    10
>  #define AT_MINSIGSTKSZ         51

This patch is corrupted with tabs changed to spaces and cannot be
applied.

> 
>  #endif /* _UAPI_ASM_RISCV_AUXVEC_H */
> ---
> 

> Signed-off-by: Victor Isaev <isv@google.com>

This needs to be in the commit message, before the --- line.
Also, you are missing a from header in your message that needs to be
added when the sending email does not match the one that has been
attributed authorship.

> Signed-off-by: Ivan Komarov <ivan.komarov@dfyz.info>

What was Ivan's contribution to the patch?

Cheers,
Conor

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv