From: Christoph Hellwig <hch@lst.de>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Maxim Kochetkov <fido_max@inbox.ru>,
Conor Dooley <conor@kernel.org>, Christoph Hellwig <hch@lst.de>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
robh@kernel.org, mpe@ellerman.id.au, aou@eecs.berkeley.edu,
palmer@dabbelt.com, paul.walmsley@sifive.com
Subject: Re: [PATCH 1/1] riscv: set ARCH_DMA_DEFAULT_COHERENT if RISCV_DMA_NONCOHERENT is not set
Date: Sat, 23 Dec 2023 05:59:12 +0100 [thread overview]
Message-ID: <20231223045912.GA21836@lst.de> (raw)
In-Reply-To: <a25d3736-f6ca-478d-8e58-69a7c0e529f7@flygoat.com>
On Fri, Dec 22, 2023 at 04:01:43PM +0000, Jiaxun Yang wrote:
>>
>> But arch_setup_dma_ops() is called only from of_dma_configure_id() and
>> acpi_dma_configure_id(). So it works only for DT and ACPI devices. What
>> about platform_device?
>
> Ah I see, that's the problem, in MIPS's use case all DMA capable devices
> are following platform's default coherency. For RISC-V we assume all device
> are enabled by ACPI or DT.
>
> Perhaps you can override it in driver, but that will make drivers platform
> dependent.
>
> I'll leave this question to Christoph.
I've already said it. You must not have DMA capable devices that aren't
declared in ACPI or OF, just like on any modern Linux platform.
What devices are you concerned about anyway Maxim?
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-12-23 4:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 18:51 [PATCH 1/1] riscv: set ARCH_DMA_DEFAULT_COHERENT if RISCV_DMA_NONCOHERENT is not set Maxim Kochetkov
2023-12-21 20:29 ` Conor Dooley
2023-12-21 22:27 ` Jiaxun Yang
2023-12-22 4:14 ` Christoph Hellwig
2023-12-22 14:39 ` Maxim Kochetkov
2023-12-22 14:54 ` Conor Dooley
2023-12-22 15:04 ` Christoph Hellwig
2023-12-22 15:38 ` Maxim Kochetkov
2023-12-22 15:45 ` Jiaxun Yang
2023-12-22 15:53 ` Maxim Kochetkov
2023-12-22 16:01 ` Jiaxun Yang
2023-12-23 4:59 ` Christoph Hellwig [this message]
2023-12-25 6:47 ` Maxim Kochetkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231223045912.GA21836@lst.de \
--to=hch@lst.de \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=fido_max@inbox.ru \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mpe@ellerman.id.au \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox