From: Conor Dooley <conor@kernel.org>
To: linux-riscv@lists.infradead.org
Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: [PATCH v2 0/7] MPFS clock fixes required for correct CAN clock modeling
Date: Mon, 22 Jan 2024 12:19:48 +0000 [thread overview]
Message-ID: <20240122-catty-roast-d3625dbb02fe@spud> (raw)
From: Conor Dooley <conor.dooley@microchip.com>
While reviewing a CAN driver internally for MPFS [1], I realised
that the modeling of the MSSPLL such that only one of its outputs could
be used was not correct. The CAN controllers on MPFS take 2 input
clocks - one that is the bus clock, acquired from the main MSSPLL and
a second clock for the AHB interface to the result of the SoC.
Currently the binding for the CAN controllers and the represetnation
of the MSSPLL only allows for one of these clocks.
Modify the binding and devicetree to expect two clocks and rework the
main clock controller driver for MPFS such that it is capable of
providing multiple outputs from the MSSPLL.
Cheers,
Conor.
1 - Hopefully that'll show up on the lists soon, once we are happy with
it ourselves. (As of v2, that's not happened yet, Christmas etc gettin
in the way, soonTM).
Changes in v2:
- Swap MSSPLL out for MSSPLL0 in the driver, there's no functional
change there.
- drop the unneeded maxItems from clocks.
CC: Conor Dooley <conor.dooley@microchip.com>
CC: Daire McNamara <daire.mcnamara@microchip.com>
CC: Wolfgang Grandegger <wg@grandegger.com>
CC: Marc Kleine-Budde <mkl@pengutronix.de>
CC: "David S. Miller" <davem@davemloft.net>
CC: Eric Dumazet <edumazet@google.com>
CC: Jakub Kicinski <kuba@kernel.org>
CC: Paolo Abeni <pabeni@redhat.com>
CC: Rob Herring <robh+dt@kernel.org>
CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC: Paul Walmsley <paul.walmsley@sifive.com>
CC: Palmer Dabbelt <palmer@dabbelt.com>
CC: Albert Ou <aou@eecs.berkeley.edu>
CC: Michael Turquette <mturquette@baylibre.com>
CC: Stephen Boyd <sboyd@kernel.org>
CC: linux-riscv@lists.infradead.org
CC: linux-can@vger.kernel.org
CC: netdev@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-clk@vger.kernel.org
Conor Dooley (7):
dt-bindings: clock: mpfs: add more MSSPLL output definitions
dt-bindings: can: mpfs: add missing required clock
clk: microchip: mpfs: split MSSPLL in two
clk: microchip: mpfs: setup for using other mss pll outputs
clk: microchip: mpfs: add missing MSSPLL outputs
clk: microchip: mpfs: convert MSSPLL outputs to clk_divider
riscv: dts: microchip: add missing CAN bus clocks
.../bindings/net/can/microchip,mpfs-can.yaml | 6 +-
arch/riscv/boot/dts/microchip/mpfs.dtsi | 4 +-
drivers/clk/microchip/clk-mpfs.c | 154 ++++++++++--------
.../dt-bindings/clock/microchip,mpfs-clock.h | 5 +
4 files changed, 98 insertions(+), 71 deletions(-)
--
2.43.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2024-01-22 12:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 12:19 Conor Dooley [this message]
2024-01-22 12:19 ` [PATCH v2 1/7] dt-bindings: clock: mpfs: add more MSSPLL output definitions Conor Dooley
2024-01-22 12:19 ` [PATCH v2 2/7] dt-bindings: can: mpfs: add missing required clock Conor Dooley
2024-01-22 13:13 ` Marc Kleine-Budde
2024-01-22 14:21 ` Conor Dooley
2024-01-22 14:46 ` Marc Kleine-Budde
2024-01-22 14:56 ` Conor Dooley
2024-01-22 15:31 ` Marc Kleine-Budde
2024-01-22 15:47 ` Conor Dooley
2024-01-30 12:11 ` Conor Dooley
2024-01-30 13:01 ` Marc Kleine-Budde
2024-02-06 14:19 ` Conor Dooley
2024-01-23 11:27 ` Krzysztof Kozlowski
2024-01-22 12:19 ` [PATCH v2 3/7] clk: microchip: mpfs: split MSSPLL in two Conor Dooley
2024-01-22 12:19 ` [PATCH v2 4/7] clk: microchip: mpfs: setup for using other mss pll outputs Conor Dooley
2024-01-22 12:19 ` [PATCH v2 5/7] clk: microchip: mpfs: add missing MSSPLL outputs Conor Dooley
2024-01-22 12:19 ` [PATCH v2 6/7] clk: microchip: mpfs: convert MSSPLL outputs to clk_divider Conor Dooley
2024-01-22 12:19 ` [PATCH v2 7/7] riscv: dts: microchip: add missing CAN bus clocks Conor Dooley
2024-02-06 14:27 ` (subset) [PATCH v2 0/7] MPFS clock fixes required for correct CAN clock modeling Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122-catty-roast-d3625dbb02fe@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mkl@pengutronix.de \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox