Re: [PATCH v1 04/11] risc: pgtable: define PFN_PTE_SHIFT

David Hildenbrand
2024-01-22T20:08:48Z

On 22.01.24 21:03, Alexandre Ghiti wrote:
> Hi David,
>
> On 22/01/2024 20:41, David Hildenbrand wrote:
>> We want to make use of pte_next_pfn() outside of set_ptes(). Let's
>> simpliy define PFN_PTE_SHIFT, required by pte_next_pfn().
>>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
>> arch/riscv/include/asm/pgtable.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
>> index 0c94260b5d0c1..add5cd30ab34d 100644
>> --- a/arch/riscv/include/asm/pgtable.h
>> +++ b/arch/riscv/include/asm/pgtable.h
>> @@ -523,6 +523,8 @@ static inline void __set_pte_at(pte_t *ptep, pte_t pteval)
>> set_pte(ptep, pteval);
>> }
>>
>> +#define PFN_PTE_SHIFT _PAGE_PFN_SHIFT
>> +
>> static inline void set_ptes(struct mm_struct *mm, unsigned long addr,
>> pte_t *ptep, pte_t pteval, unsigned int nr)
>> {
>
>
> There is a typo in the commit title: risc -> riscv. Otherwise, this is
> right so:

Whops :)

>
> Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>

Thanks!

--
Cheers,

David / dhildenb