[PATCH 1/1] firmware: microchip: fix wrong sizeof argument

[PATCH 1/1] firmware: microchip: fix wrong sizeof argument

[Samasth Norway Ananda]

response_msg is a pointer to an unsigned int (u32). So passing just
response_msg to sizeof would not print the size of the variable. To get
the size of response_msg we need to pass it as a pointer variable.

Fixes: ec5b0f1193ad ("firmware: microchip: add PolarFire SoC Auto Update support")
Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
---
 drivers/firmware/microchip/mpfs-auto-update.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/microchip/mpfs-auto-update.c b/drivers/firmware/microchip/mpfs-auto-update.c
index 81f5f62e34fc..682e417be5a3 100644
--- a/drivers/firmware/microchip/mpfs-auto-update.c
+++ b/drivers/firmware/microchip/mpfs-auto-update.c
@@ -167,7 +167,7 @@ static int mpfs_auto_update_verify_image(struct fw_upload *fw_uploader)
 	u32 *response_msg;
 	int ret;
 
-	response_msg = devm_kzalloc(priv->dev, AUTO_UPDATE_FEATURE_RESP_SIZE * sizeof(response_msg),
+	response_msg = devm_kzalloc(priv->dev, AUTO_UPDATE_FEATURE_RESP_SIZE * sizeof(*response_msg),
 				    GFP_KERNEL);
 	if (!response_msg)
 		return -ENOMEM;
-- 
2.42.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH 1/1] firmware: microchip: fix wrong sizeof argument

[Conor Dooley]

From: Conor Dooley <conor.dooley@microchip.com>

On Thu, 25 Jan 2024 13:19:33 -0800, Samasth Norway Ananda wrote:
> response_msg is a pointer to an unsigned int (u32). So passing just
> response_msg to sizeof would not print the size of the variable. To get
> the size of response_msg we need to pass it as a pointer variable.
> 
> 

Applied to riscv-soc-drivers-fixes, thanks!

[1/1] firmware: microchip: fix wrong sizeof argument
      https://git.kernel.org/conor/c/0abcac4fe3ca

Thanks,
Conor.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv