From: Conor Dooley <conor@kernel.org>
To: Ziv Xu <ziv.xu@starfivetech.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Walker Chen <walker.chen@starfivetech.com>,
Xingyu Wu <xingyu.wu@starfivetech.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 2/3] clocksource: Add JH7110 timer driver
Date: Tue, 19 Mar 2024 08:19:04 +0000 [thread overview]
Message-ID: <20240319-vivacious-anointer-cf790d8852c1@spud> (raw)
In-Reply-To: <20240318030649.10413-3-ziv.xu@starfivetech.com>
[-- Attachment #1.1: Type: text/plain, Size: 506 bytes --]
On Mon, Mar 18, 2024 at 11:06:48AM +0800, Ziv Xu wrote:
> +static int jh7110_timer_start(struct jh7110_clkevt *clkevt)
> +{
> + int ret;
> +
> + /* Disable and clear interrupt first */
> + writel(JH7110_TIMER_INT_DIS, clkevt->base + JH7110_TIMER_INT_MASK);
> + ret = jh7110_timer_int_clear(clkevt);
The return value here is not checked/used.
> + writel(JH7110_TIMER_INT_ENA, clkevt->base + JH7110_TIMER_INT_MASK);
> + writel(JH7110_TIMER_ENA, clkevt->base + JH7110_TIMER_ENABLE);
> +
> + return 0;
> +}
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-03-19 8:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 3:06 [PATCH v9 0/3] Add timer driver for StarFive JH7110 RISC-V SoC Ziv Xu
2024-03-18 3:06 ` [PATCH v9 1/3] dt-bindings: timer: Add timer for StarFive JH7110 SoC Ziv Xu
2024-03-18 3:06 ` [PATCH v9 2/3] clocksource: Add JH7110 timer driver Ziv Xu
2024-03-19 8:19 ` Conor Dooley [this message]
2024-03-20 1:40 ` 回复: " Ziv Xu
2024-03-18 3:06 ` [PATCH v9 3/3] riscv: dts: jh7110: starfive: Add timer node Ziv Xu
2024-03-28 7:27 ` 回复: [PATCH v9 0/3] Add timer driver for StarFive JH7110 RISC-V SoC Ziv Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240319-vivacious-anointer-cf790d8852c1@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=walker.chen@starfivetech.com \
--cc=xingyu.wu@starfivetech.com \
--cc=ziv.xu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox