Re: [PATCH v2 1/2] riscv: thead: Rename T-Head PBMT to MAEE

From: Conor Dooley <conor@kernel.org>
To: "Christoph Müllner" <christoph.muellner@vrull.eu>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Philipp Tomsich" <philipp.tomsich@vrull.eu>,
	"Björn Töpel" <bjorn@kernel.org>,
	"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Cooper Qu" <cooper.qu@linux.alibaba.com>,
	"Zhiwei Liu" <zhiwei_liu@linux.alibaba.com>,
	"Huang Tao" <eric.huang@linux.alibaba.com>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Andrew Jones" <ajones@ventanamicro.com>,
	"Qingfang Deng" <dqfext@gmail.com>,
	"Alexandre Ghiti" <alex@ghiti.fr>
Subject: Re: [PATCH v2 1/2] riscv: thead: Rename T-Head PBMT to MAEE
Date: Thu, 4 Apr 2024 17:06:50 +0100	[thread overview]
Message-ID: <20240404-pastime-reassign-2d23a6ea6265@spud> (raw)
In-Reply-To: <20240329121414.688391-2-christoph.muellner@vrull.eu>

[-- Attachment #1.1: Type: text/plain, Size: 1410 bytes --]

On Fri, Mar 29, 2024 at 01:14:13PM +0100, Christoph Müllner wrote:
> T-Head's vendor extension to set page attributes has the name
> MAEE (MMU address attribute extension).
> Let's rename it, so it is clear what this referes to.
> 
> See also:
>   https://github.com/T-head-Semi/thead-extension-spec/blob/master/xtheadmaee.adoc

If there's a resend, make this a Link: tag please.

> Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
> ---
>  arch/riscv/Kconfig.errata            |  8 ++++----
>  arch/riscv/errata/thead/errata.c     |  8 ++++----
>  arch/riscv/include/asm/errata_list.h | 20 ++++++++++----------
>  3 files changed, 18 insertions(+), 18 deletions(-)
> 
> diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata
> index 910ba8837add..2c24bef7e112 100644
> --- a/arch/riscv/Kconfig.errata
> +++ b/arch/riscv/Kconfig.errata
> @@ -82,14 +82,14 @@ config ERRATA_THEAD
>  
>  	  Otherwise, please say "N" here to avoid unnecessary overhead.
>  
> -config ERRATA_THEAD_PBMT
> -	bool "Apply T-Head memory type errata"
> +config ERRATA_THEAD_MAEE
> +	bool "Apply T-Head's MMU address attribute (MAEE)"
>  	depends on ERRATA_THEAD && 64BIT && MMU
>  	select RISCV_ALTERNATIVE_EARLY
>  	default y

Since this defaults to enabled, changing the name should be fair game.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv