From: Conor Dooley <conor.dooley@microchip.com>
To: <wefu@redhat.com>
Cc: <jszhang@kernel.org>, <alexandre.belloni@bootlin.com>,
<robh@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <guoren@kernel.org>,
<paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>, <linux-riscv@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-rtc@vger.kernel.org>
Subject: Re: [PATCH 4/5] Kconfig: Enable APM X-Gene RTC for XuanTie TH1520
Date: Fri, 12 Apr 2024 10:47:36 +0100 [thread overview]
Message-ID: <20240412-ogle-daily-c18bc6e7ddd5@wendy> (raw)
In-Reply-To: <20240412080238.134191-5-wefu@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1074 bytes --]
On Fri, Apr 12, 2024 at 04:01:46PM +0800, wefu@redhat.com wrote:
> From: Wei Fu <wefu@redhat.com>
>
> This patch enables APM X-Gene RTC for XuanTie TH1520.
>
> Signed-off-by: Wei Fu <wefu@redhat.com>
> ---
> drivers/rtc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 3a89f1e6095d..b219aeef4ce9 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1880,7 +1880,7 @@ config RTC_DRV_MT7622
> config RTC_DRV_XGENE
> tristate "APM X-Gene RTC"
> depends on HAS_IOMEM
> - depends on ARCH_XGENE || COMPILE_TEST
> + depends on ARCH_XGENE || ARCH_THEAD || COMPILE_TEST
> help
> If you say yes here you get support for the APM X-Gene SoC real time
> clock.
If I was configuring my system by reading menuconfig, I would have
absolutely no idea that this driver supports platforms other than the
X-Gene one. I think the Kconfig stuff for this likely needs an update to
convey that it's no longer just one SoC family that's supported here.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-04-12 9:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 8:01 [PATCH 0/5] RTC: update APM X-Gene RTC driver by adding the pre-scaler support wefu
2024-04-12 8:01 ` [PATCH 1/5] drivers/rtc/rtc-xgene: Add prescaler support in APM X-Gene RTC driver wefu
2024-04-12 8:23 ` Alexandre Belloni
2024-04-12 8:01 ` [PATCH 2/5] dt-bindings: rtc: Add optional property "prescaler" in APM X-Gene RTC Document wefu
2024-04-12 8:20 ` Alexandre Belloni
2024-04-12 8:01 ` [PATCH 3/5] drivers/rtc/rtc-xgene: Add "snps,dw-apb-rtc" into the "compatible" wefu
2024-04-12 9:17 ` Krzysztof Kozlowski
2024-04-12 9:39 ` Conor Dooley
2024-04-12 8:01 ` [PATCH 4/5] Kconfig: Enable APM X-Gene RTC for XuanTie TH1520 wefu
2024-04-12 9:47 ` Conor Dooley [this message]
2024-04-12 8:01 ` [PATCH 5/5] riscv: dts: thead: Add XuanTie TH1520 RTC device node wefu
2024-04-12 8:21 ` Alexandre Belloni
2024-04-12 9:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412-ogle-daily-c18bc6e7ddd5@wendy \
--to=conor.dooley@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoren@kernel.org \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox