Re: [PATCH v2 06/17] riscv: Extend cpufeature.c to detect vendor extensions

Conor Dooley
2024-04-17T13:43:01Z

[-- Attachment #1.1: Type: text/plain, Size: 693 bytes --]

On Mon, Apr 15, 2024 at 09:12:03PM -0700, Charlie Jenkins wrote:

> @@ -351,6 +343,14 @@ static void __init riscv_parse_isa_string(unsigned long *this_hwcap, struct risc
> bool ext_long = false, ext_err = false;
>
> switch (*ext) {
> + case 'x':
> + case 'X':
> + pr_warn("Vendor extensions are ignored in riscv,isa. Use riscv,isa-extensions instead.");

Was looking for something and noticed this - pr_warn_once() I think.

> + /*
> + * In canonical order, the remaining extensions in the
> + * isa string will be vendor extensions so exit.
> + */
> + break;
> case 's':
> /*
> * Workaround for invalid single-letter 's' & 'u' (QEMU).

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]