Re: [PATCH v2 00/17] riscv: Support vendor extensions and xtheadvector

Conor Dooley
2024-04-16T15:39:54Z

[-- Attachment #1.1: Type: text/plain, Size: 1184 bytes --]

On Mon, Apr 15, 2024 at 09:11:57PM -0700, Charlie Jenkins wrote:

> Changes in v2:
> - Added commit hash to xtheadvector
> - Simplified riscv,isa vector removal fix to not mess with the DT
> riscv,vendorid
> - Moved riscv,vendorid parsing into a different patch and cache the
> value to be used by alternative patching
> - Reduce riscv,vendorid missing severity to "info"
> - Separate vendor extension list to vendor files
> - xtheadvector no longer puts v in the elf_hwcap

> - Only patch vendor extension if all harts are associated with the same
> vendor. This is the best chance the kernel has for working properly if
> there are multiple vendors.

I don't agree with this lack of trust in what firmware is telling us.

I'm not really gonna review this v2 until discussion has finished in v1
about some things, I fundamentally disagree with handling the same
extension differently for different CPU vendors and I don't wanna
fracture that conversation further.

> - Split hwprobe vendor keys out into vendor file
> - Add attribution for Heiko's patches
> - Link to v1: https://lore.kernel.org/r/20240411-dev-charlie-support_thead_vector_6_9-v1-0-4af9815ec746@rivosinc.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]