Re: [PATCH v6 1/2] dt-bindings: riscv: add Milk-V Duo S board compatibles

Krzysztof Kozlowski
2024-04-21T14:12:37Z

On 21/04/2024 07:57, michael.opdenacker@bootlin.com wrote:
> From: Michael Opdenacker <michael.opdenacker@bootlin.com>
>
> Document the compatible strings for the Milk-V Duo S board[1] which uses
> the SOPHGO SG2000 SoC, compatible with the CV1812H SoC[2].
>
> Link: https://milkv.io/duo-s [1]
> Link: https://en.sophgo.com/product/introduce/cv181xH.html [2]
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> ---

Where is the changelog? It's v6!

> Documentation/devicetree/bindings/riscv/sophgo.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> index 9bc813dad098..79546aa21021 100644
> --- a/Documentation/devicetree/bindings/riscv/sophgo.yaml
> +++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> @@ -24,6 +24,7 @@ properties:
> - const: sophgo,cv1800b
> - items:
> - enum:
> + - milkv,duo-s

? It was duo... and duos... now weirdly duo-s without explanation.

> - sophgo,huashan-pi
> - const: sophgo,cv1812h

It was CV1800 before... and you were asked for SoC compatible.

Please reach to your Bootlin folks to explain you how to send new
versions of patchsets and how to use compatibles.

Best regards,
Krzysztof