From: Andrew Jones <ajones@ventanamicro.com>
To: Conor Dooley <conor@kernel.org>
Cc: linux-riscv@lists.infradead.org, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu,
cuiyunhui@bytedance.com, woodrow.shen@sifive.com
Subject: Re: [PATCH] RISC-V: selftests: cbo: Ensure asm operands match constraints, take 2
Date: Wed, 24 Apr 2024 12:33:28 +0200 [thread overview]
Message-ID: <20240424-d96185a44365c73d606c6526@orel> (raw)
In-Reply-To: <20240424-familiar-subdued-74d8922444df@spud>
On Wed, Apr 24, 2024 at 10:41:10AM +0100, Conor Dooley wrote:
> On Fri, Mar 22, 2024 at 02:47:28PM +0100, Andrew Jones wrote:
> > Commit 0de65288d75f ("RISC-V: selftests: cbo: Ensure asm operands
> > match constraints") attempted to ensure MK_CBO() would always
> > provide to a compile-time constant when given a constant, but
> > cpu_to_le32() isn't necessarily going to do that. Switch to manually
> > shifting the bytes, when needed, to finally get this right.
> >
> > Reported-by: Woodrow Shen <woodrow.shen@sifive.com>
> > Closes: https://lore.kernel.org/all/CABquHATcBTUwfLpd9sPObBgNobqQKEAZ2yxk+TWSpyO5xvpXpg@mail.gmail.com/
> > Fixes: a29e2a48afe3 ("RISC-V: selftests: Add CBO tests")
> > Fixes: 0de65288d75f ("RISC-V: selftests: cbo: Ensure asm operands match constraints")
> > Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
>
> This has been sitting in patchwork for a while and I don't see a message
> from either the reporter saying this was a good fix or from the selftests
> maintainer that it has been picked up. I was gonna mark it "handled
> elsewhere" but I noticed that this was only sent to the riscv
> maintainers so we should probably harass Palmer today to pick this up?
>
Yup. Thanks for the reminder to follow up!
drew
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-04-24 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 13:47 [PATCH] RISC-V: selftests: cbo: Ensure asm operands match constraints, take 2 Andrew Jones
2024-04-24 9:41 ` Conor Dooley
2024-04-24 10:33 ` Andrew Jones [this message]
2024-04-24 11:05 ` Woodrow Shen
2024-04-25 23:00 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424-d96185a44365c73d606c6526@orel \
--to=ajones@ventanamicro.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=cuiyunhui@bytedance.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=woodrow.shen@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox