From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D116BC19F4F for ; Tue, 7 May 2024 23:29:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YGBRKj5x59crXzWkrT25vbVmb5DNyrdVTfXlL2TPqCo=; b=NfJZ+Llpd9Jksz EEdxkCXAvPCAq1svXDOjRIfrEl7WZvJwEJHPdRfpVpV9hrlyjsAHbVBe8XDge9LzF1691TOF28Ped 6ZAgSTjXm/Hym7sIQCJMNXR+PGZEi+2G4ix9tFgp0QJ7Fs2LkBOeC+EOsE6jzVRRWdMvRAoMRWcCa mvE7Xuj7LblI+AWAHSFgE7iL5cJiXYAi64flOv+BAhMZ6B24jsrUBwQaa81+0ljZFRmd6KI+PCzU4 +8M5ipYSmpawbEkbf7CmjNpS1sc0+c+18SHSB5C3q99i/8qMyNn+HjwEmy1apD5v9aCu4QqeYyjH8 xyQ+7VDZkshgZT5O6a3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4UF3-0000000DIWM-2u8j; Tue, 07 May 2024 23:29:01 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4UF0-0000000DISa-0Dtj for linux-riscv@lists.infradead.org; Tue, 07 May 2024 23:29:00 +0000 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6f4551f2725so3586894b3a.1 for ; Tue, 07 May 2024 16:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715124534; x=1715729334; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Tt8XgRQm+eA+VmBxGqEcvvy66oE9R2AfbLeL3WkCPuU=; b=bUlbk6Qflmz8ceyV0U8yqimTCuqsMgJeFvPbe/fG1hLHnoo6WkYp9xaMj7NmBwV/Yg Gveb96iQHjrRV24lma1uk5JBOqXZ7HbM+cgDdVBT4BLGOnhvQYckqYgobwDF5UwauLdE qa97AZliwhAv5AdO3DNqZHbwQckYaG/rYtjIU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715124534; x=1715729334; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Tt8XgRQm+eA+VmBxGqEcvvy66oE9R2AfbLeL3WkCPuU=; b=Ex2qG5ZqHV8U6oUo53sngNdp/d7T61myECu2FhRf6Ze3YWSFWIaMCtmYYd4c+2vxFK p7XG9KbtPJ+oOVbMYfhXpvxxVnlOEulS8ABeWvBthcsV/PGftK2klsi1mfEDyRW4jbnh /pPO7Zu7wuZfzO+Z64q1G1pKMoNCx3fLBtPuD3pZcZq95JggGuObl8WkP5Vz3l2yVnUz /ddNBxTjWJPfTJ91SwkJa17rBeaSGtsp1Bu9LZcv9D9USJumoUHMGG971F+8CCIntX8i CLTUO1OVAXVwGilAZj2XlEcwX8ae7//b4/jq4G+SV5BWtHGOuT2I9fVrf8r/kzMi68p2 YEaw== X-Forwarded-Encrypted: i=1; AJvYcCX6j2f8NInCa394GG/+qlvKow20Ngo0K2x/tLBMthSEV0pMIUKu9Sk4SveTkE+aG1A3MlHvNAV16Vz6olMSm9w9jHH4WdrhRJZPj74FgYsT X-Gm-Message-State: AOJu0Yz49UhVTMVCcswxQsRbs9ASlIeE/iVNWrvq4GaaPvI4dNtcu+8s lmirQMcrdlnyc82R3WliheG7cupDuEIWy7atk4lXty/hIML/YXSzsV0xzZuOsg== X-Google-Smtp-Source: AGHT+IElkYKkPF9F5WlZiOfJXRbgeCSMUqbJ3Z1JrZ5HzzcuDvdHCUlR3LVeoTae63dQgTdtTlamYA== X-Received: by 2002:a05:6a20:9f88:b0:1ad:6c5:4ea1 with SMTP id adf61e73a8af0-1afc8db5479mr1525582637.41.1715124534335; Tue, 07 May 2024 16:28:54 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id 60-20020a17090a09c200b002b624b0161fsm80422pjo.19.2024.05.07.16.28.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 16:28:53 -0700 (PDT) Date: Tue, 7 May 2024 16:28:53 -0700 From: Kees Cook To: Edward Liaw Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?iso-8859-1?Q?Andr=E9?= Almeida , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 0/5] Define _GNU_SOURCE for sources using Message-ID: <202405071628.7F8C3EC@keescook> References: <20240507214254.2787305-1-edliaw@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240507214254.2787305-1-edliaw@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_162858_166297_3714F8DA X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, May 07, 2024 at 09:38:25PM +0000, Edward Liaw wrote: > 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced > asprintf into kselftest_harness.h, which is a GNU extension and needs > _GNU_SOURCE to either be defined prior to including headers or with the > -D_GNU_SOURCE flag passed to the compiler. > > v1: https://lore.kernel.org/linux-kselftest/20240430235057.1351993-1-edliaw@google.com/ > v2: add -D_GNU_SOURCE to KHDR_INCLUDES so that it is in a single > location. Remove #define _GNU_SOURCE from source code to resolve > redefinition warnings. > > Edward Liaw (5): > selftests: Compile kselftest headers with -D_GNU_SOURCE > selftests/sgx: Include KHDR_INCLUDES in Makefile > selftests: Include KHDR_INCLUDES in Makefile > selftests: Drop define _GNU_SOURCE > selftests: Drop duplicate -D_GNU_SOURCE It's a lot of churn, but I don't see a way to do it differently. :) Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv