Re: [PATCH v1 5/9] dt-bindings: interrupt-controller: Add SpacemiT K1 PLIC

Conor Dooley
2024-06-18T15:44:27Z

[-- Attachment #1.1: Type: text/plain, Size: 1484 bytes --]

On Mon, Jun 17, 2024 at 01:20:50AM +0800, Yangyu Chen wrote:
> Add compatible string for SpacemiT K1 PLIC.
>
> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> ---
> .../bindings/interrupt-controller/sifive,plic-1.0.0.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml
> index 709b2211276b..3d0426b56904 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml
> @@ -59,6 +59,7 @@ properties:
> - enum:
> - canaan,k210-plic
> - sifive,fu540-c000-plic
> + - spacemit,k1-plic
> - starfive,jh7100-plic
> - starfive,jh7110-plic
> - const: sifive,plic-1.0.0
> @@ -71,7 +72,9 @@ properties:
> - thead,th1520-plic
> - const: thead,c900-plic
> - items:
> - - const: sifive,plic-1.0.0
> + - enum:
> + - sifive,plic-1.0.0
> + - spacemit,k1-plic

Why in two places? This isn't sifive IP, so I think we should go with
this one here.

> - const: riscv,plic0
> deprecated: true
> description: For the QEMU virt machine only
> --
> 2.45.1
>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]