Re: [PATCH v1 4/9] dt-bindings: timer: Add SpacemiT K1 CLINT

Conor Dooley
2024-06-18T17:05:33Z

[-- Attachment #1.1: Type: text/plain, Size: 895 bytes --]

On Tue, Jun 18, 2024 at 11:48:26PM +0800, Yangyu Chen wrote:
>
> > On Jun 18, 2024, at 23:40, Conor Dooley <conor@kernel.org> wrote:
> >
> > On Mon, Jun 17, 2024 at 01:20:49AM +0800, Yangyu Chen wrote:
> >> Add compatible string for SpacemiT K1 CLINT.
> >>
> >> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> >
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Actually, I'm not confident about this after carefully reviewing
> the file. The "riscv,clint0" is marked deprecated, and the description
> is For the QEMU virtual machine only.

Right, I forgot about that portion of it. Probably, if this is sifive
plic compatible, then fall back to the sifive clint. Same, I suppose,
goes for the plic etc. The alternative is not have a fallback, modify
the driver, and future spacemit things will fall back to the k1's
compatible. I don't mind which you go for.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]