Re: [PATCH v1 7/9] riscv: dts: add initial SpacemiT K1 SoC device tree

Yixun Lan
2024-06-16T22:53:43Z

On 01:20 Mon 17 Jun , Yangyu Chen wrote:
> Banana Pi BPI-F3 motherboard is powered by SpacemiT K1[1].
>
.. snip
> + uart0: serial@d4017000 {
> + compatible = "intel,xscale-uart";
are you sure the uart IP is fully compatible with xscale?
otherwise I'd suggest to introduce a vendor specific one..

> + reg = <0x0 0xd4017000 0x0 0x100>;
> + interrupts = <42>;
> + clock-frequency = <14000000>;
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + status = "disabled";
> + };
> + };
> +};
it's better to also add other uart nodes, I feel it's more complete

--
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55