Re: [PATCH v3 0/3] Add I2C support on TH1520

From: Conor Dooley <conor.dooley@microchip.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: "Thomas Bonnefille" <thomas.bonnefille@bootlin.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Jisheng Zhang" <jszhang@kernel.org>,
	"Guo Ren" <guoren@kernel.org>, "Fu Wei" <wefu@redhat.com>,
	"Drew Fustini" <dfustini@tenstorrent.com>,
	"Emil Renner Berthing" <emil.renner.berthing@canonical.com>,
	"Conor Dooley" <conor@kernel.org>,
	"Jarkko Nikula" <jarkko.nikula@linux.intel.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Miquèl Raynal" <miquel.raynal@bootlin.com>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 0/3] Add I2C support on TH1520
Date: Fri, 28 Jun 2024 11:49:23 +0100	[thread overview]
Message-ID: <20240628-joining-blooming-64aefbfd9897@wendy> (raw)
In-Reply-To: <xkdmrmtiizoqo6mpc7i6iyhilxlw57nawn6ogv6dryaveyqddc@ach3rwy4abpe>

[-- Attachment #1.1: Type: text/plain, Size: 2247 bytes --]

On Fri, Jun 28, 2024 at 11:30:28AM +0200, Andi Shyti wrote:
> Hi,
> 
> On Tue, Jun 18, 2024 at 09:42:37AM GMT, Thomas Bonnefille wrote:
> > This adds I2C support in the device tree of the T-Head TH1520 RISCV-SoC
> > and a default configuration for the BeagleV-Ahead. It appears that the
> > TH1520 I2C is already supported in the upstream kernel through the
> > Synopsis Designware I2C adapter driver.
> > 
> > This patch depends on the clock patch from Drew Fustini
> > Link: https://lore.kernel.org/linux-riscv/20240615-th1520-clk-v1-0-3ba4978c4d6b@tenstorrent.com
> > and the pinctrl patch from Emil Renner Berthing
> > Link: https://lore.kernel.org/linux-riscv/20240103132852.298964-1-emil.renner.berthing@canonical.com
> 
> I think after these two go in...
> 
> > Changed from v1:
> > 1. Remove redundant example for Synopsis DesignWare-I2C bindings
> > 2. Remove Node Ordering commit as it has already been taken
> > 3. Remove EEPROM label
> > 4. Rebase on pinctrl and clock driver patches
> > 5. Add pinctrl configuration
> > 6. Replaced the fixed-clock with a correct configuration
> > 
> > Changed from v2:
> > 1. Reorder nodes to conserve ascending register node ordering
> > 2. Add support for I2C2 as it probably use the same controller
> > 3. Format comments to match kernel coding style
> > 4. Reorder nodes to conserve alphabetical node ordering
> > 6. Declare I2C2
> > 6. Set pinctrl pull-up resistor to the highest value
> > 
> > Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
> > ---
> > Thomas Bonnefille (3):
> >       dt-bindings: i2c: dw: Document compatible thead,th1520-i2c
> 
> ... this goes throught i2c...
> 
> >       riscv: dts: thead: Add TH1520 I2C nodes
> >       riscv: dts: thead: Enable I2C on the BeagleV-Ahead
> 
> ... and these two go thrhough Conor's branches.
> 
> Do you mind sending a ping when Drew's patches are included in
> the merge window? I can put the first patch on a special branch
> to keep it under my watch.

I think you can apply the binding whenever you want actually, there's no
need for the i2c binding (or driver changes, were there to be any) to
be held until the clock binding/driver is accepted.

Thanks,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv