Re: [PATCH v3 06/11] dt-bindings: serial: 8250: Add SpacemiT K1 uart compatible

From: Yixun Lan <dlan@gentoo.org>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Conor Dooley <conor@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Samuel Holland <samuel.holland@sifive.com>,
	Anup Patel <anup@brainfault.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Lubomir Rintel <lkundrak@v3.sk>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yangyu Chen <cyy@cyyself.name>,
	Conor Dooley <conor.dooley@microchip.com>,
	Inochi Amaoto <inochiama@outlook.com>,
	linux-serial@vger.kernel.org, linux-riscv@lists.infradead.org,
	Meng Zhang <zhangmeng.kevin@spacemit.com>
Subject: Re: [PATCH v3 06/11] dt-bindings: serial: 8250: Add SpacemiT K1 uart compatible
Date: Fri, 5 Jul 2024 06:47:21 +0000	[thread overview]
Message-ID: <20240705064721.GB3042186@ofsar> (raw)
In-Reply-To: <ZoarsYMNJRu1-_wn@xhacker>


On 22:03 Thu 04 Jul     , Jisheng Zhang wrote:
> On Wed, Jul 03, 2024 at 02:55:09PM +0000, Yixun Lan wrote:
> > Found SpacemiT's K1 uart controller is compatible with
> > Intel's Xscale uart, but it's still worth to introduce a new compatible.
> 
> Per vendor's kernel source code, all the uarts support 64Bytes FIFO.
> So if it's compatible with Xscale, it's a xscale uart 64 Bytes FIFO.
yes, I agree

further question would how to implement specific support for spacemit's k1 SoC
one possible option to add a PORT_SPACEMIT compatible data to 8250_port.c - uart_config[]


> >From this PoV, the uart isn't a Xscale but a mrvl pxa.
see my previous comment, probably need further clarification/investigation..

> 
> But I have one question: is the uart really a mrvl/intel pxa uart? or is just
No, I'm unable to answer this, I'm not an employee of SpacemiT
All informations are based on public available source + docs..

> reg programming compatible with pxa?
> 
To my knowledge, it's compatible with pxa, but it would be great that vendor can clarify this

> > 
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > Signed-off-by: Yixun Lan <dlan@gentoo.org>
> > ---
> >  Documentation/devicetree/bindings/serial/8250.yaml | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml
> > index 692aa05500fd5..0bde2379e8647 100644
> > --- a/Documentation/devicetree/bindings/serial/8250.yaml
> > +++ b/Documentation/devicetree/bindings/serial/8250.yaml
> > @@ -111,7 +111,9 @@ properties:
> >                - mediatek,mt7623-btif
> >            - const: mediatek,mtk-btif
> >        - items:
> > -          - const: mrvl,mmp-uart
> > +          - enum:
> > +              - mrvl,mmp-uart
> > +              - spacemit,k1-uart
> >            - const: intel,xscale-uart
> >        - items:
> >            - enum:
> > 
> > -- 
> > 2.45.2
> > 
> > 
> > _______________________________________________
> > linux-riscv mailing list
> > linux-riscv@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-riscv

-- 
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv