Re: [PATCH v4 4/4] RISC-V: Use Zkr to seed KASLR base address

Conor Dooley
2024-07-10T14:25:00Z

[-- Attachment #1.1: Type: text/plain, Size: 840 bytes --]

On Tue, Jul 09, 2024 at 01:39:37PM -0400, Jesse Taube wrote:
> Parse the device tree for Zkr in the isa string.
> If Zkr is present, use it to seed the kernel base address.
>
> On an ACPI system, as of this commit, there is no easy way to check if
> Zkr is present. Blindly running the instruction isn't an option as;
> we have to be able to trust the firmware.
>
> Signed-off-by: Jesse Taube <jesse@rivosinc.com>
> Reviewed-by: Charlie Jenkins <charlie@rivosinc.com>
> Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>
> Tested-by: Zong Li <zong.li@sifive.com>

My heads a bit addled from being sick still, but I think you've dealt
with the things I had send on the previous version and I didn't spot any
obvious problems with the parsing.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]