From: Conor Dooley <conor@kernel.org>
To: Jesse Taube <jesse@rivosinc.com>
Cc: linux-riscv@lists.infradead.org, Ard Biesheuvel <ardb@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Alexandre Ghiti <alexghiti@rivosinc.com>,
Conor Dooley <conor.dooley@microchip.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Wende Tan <twd2.me@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Sami Tolvanen <samitolvanen@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <bhe@redhat.com>,
"Mike Rapoport (IBM)" <rppt@kernel.org>,
"Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Charlie Jenkins <charlie@rivosinc.com>,
Zong Li <zong.li@sifive.com>
Subject: Re: [PATCH v4 4/4] RISC-V: Use Zkr to seed KASLR base address
Date: Wed, 10 Jul 2024 15:23:50 +0100 [thread overview]
Message-ID: <20240710-stroller-serve-3ab5d6d8d5a1@spud> (raw)
In-Reply-To: <20240709173937.510084-5-jesse@rivosinc.com>
[-- Attachment #1.1: Type: text/plain, Size: 840 bytes --]
On Tue, Jul 09, 2024 at 01:39:37PM -0400, Jesse Taube wrote:
> Parse the device tree for Zkr in the isa string.
> If Zkr is present, use it to seed the kernel base address.
>
> On an ACPI system, as of this commit, there is no easy way to check if
> Zkr is present. Blindly running the instruction isn't an option as;
> we have to be able to trust the firmware.
>
> Signed-off-by: Jesse Taube <jesse@rivosinc.com>
> Reviewed-by: Charlie Jenkins <charlie@rivosinc.com>
> Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>
> Tested-by: Zong Li <zong.li@sifive.com>
My heads a bit addled from being sick still, but I think you've dealt
with the things I had send on the previous version and I didn't spot any
obvious problems with the parsing.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-07-10 14:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 17:39 [PATCH v4 0/4] RISC-V: Parse DT for Zkr to seed KASLR Jesse Taube
2024-07-09 17:39 ` [PATCH v4 1/4] RISC-V: pi: Force hidden visibility for all symbol references Jesse Taube
2024-07-09 17:39 ` [PATCH v4 2/4] RISC-V: lib: Add pi aliases for string functions Jesse Taube
2024-07-09 17:39 ` [PATCH v4 3/4] RISC-V: pi: Add kernel/pi/pi.h Jesse Taube
2024-07-09 17:39 ` [PATCH v4 4/4] RISC-V: Use Zkr to seed KASLR base address Jesse Taube
2024-07-10 14:23 ` Conor Dooley [this message]
2024-08-14 14:10 ` [PATCH v4 0/4] RISC-V: Parse DT for Zkr to seed KASLR patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710-stroller-serve-3ab5d6d8d5a1@spud \
--to=conor@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexghiti@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=bhe@redhat.com \
--cc=charlie@rivosinc.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor.dooley@microchip.com \
--cc=jesse@rivosinc.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=twd2.me@gmail.com \
--cc=vishal.moola@gmail.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox