Re: [PATCH RFC] riscv: Allow to build only with LLVM >= 17.0.0

From: Conor Dooley <conor@kernel.org>
To: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: "Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Björn Töpel" <bjorn@rivosinc.com>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	"kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH RFC] riscv: Allow to build only with LLVM >= 17.0.0
Date: Wed, 17 Jul 2024 12:32:21 +0100	[thread overview]
Message-ID: <20240717-synapse-decade-a0d41bd7afce@spud> (raw)
In-Reply-To: <20240717111716.157149-1-alexghiti@rivosinc.com>


[-- Attachment #1.1: Type: text/plain, Size: 1787 bytes --]

On Wed, Jul 17, 2024 at 01:17:16PM +0200, Alexandre Ghiti wrote:
> The following build failure happens when using LLVM < 17.0.0:
> 
> kernel/sched/core.c:11873:7: error: cannot jump from this asm goto statement to one of its possible targets
> 
> This is a known issue [1] so let's upgrade the minimal requirement for
> LLVM to the version 17.0.0, which is the first version to contain the
> fix.

I think doing this unilaterally is kinda insane, LLVM 17 isn't even a
year old. Debian testing doesn't have anything later than 16. Why does
it need to be done unilaterally rather than just when the qspinlock
stuff is built?
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/1886#issuecomment-1645979992 [1]
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202407041157.odTZAYZ6-lkp@intel.com/
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

If Nathan wrote the patch, you need to set him as the author of the
patch :)

> Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
> ---
> 
> This patch was done by Nathan, I'm just sending it as an RFC to get quicker
> feedbacks.
> 
> I tested it successfully.
> 
> Note that the build failure happens on the not-yet merged qspinlock
> patchset.
> 
>  scripts/min-tool-version.sh | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh
> index 91c91201212c..e81eb7ed257d 100755
> --- a/scripts/min-tool-version.sh
> +++ b/scripts/min-tool-version.sh
> @@ -28,6 +28,8 @@ llvm)
>  		echo 15.0.0
>  	elif [ "$SRCARCH" = loongarch ]; then
>  		echo 18.0.0
> +	elif [ "$SRCARCH" = riscv ]; then
> +		echo 17.0.0
>  	else
>  		echo 13.0.1
>  	fi
> -- 
> 2.39.2
> 
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv