From: Conor Dooley <conor@kernel.org>
To: "Clément Léger" <cleger@rivosinc.com>
Cc: linux-riscv@lists.infradead.org,
Conor Dooley <conor.dooley@microchip.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] RISC-V: hwprobe: sort EXT_KEY()s in hwprobe_isa_ext0() alphabetically
Date: Wed, 17 Jul 2024 14:42:30 +0100 [thread overview]
Message-ID: <20240717-unluckily-collide-1aa35c97662c@spud> (raw)
In-Reply-To: <cba0c880-a1b2-4bb8-bef0-d280d87ec308@rivosinc.com>
[-- Attachment #1.1: Type: text/plain, Size: 1427 bytes --]
On Wed, Jul 17, 2024 at 03:34:06PM +0200, Clément Léger wrote:
> On 17/07/2024 10:54, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> >
> > Currently the entries appear to be in a random order (although according
> > to Palmer he has tried to sort them by key value) which makes it harder
> > to find entries in a growing list, and more likely to have conflicts as
> > all patches are adding to the end of the list. Sort them alphabetically
> > instead.
> >
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> > if (has_fpu()) {
> > - EXT_KEY(ZFH);
> > - EXT_KEY(ZFHMIN);
> > - EXT_KEY(ZFA);
> > EXT_KEY(ZCD);
> > EXT_KEY(ZCF);
> > + EXT_KEY(ZFA);
> > + EXT_KEY(ZFH);
> > + EXT_KEY(ZFHMIN);
> > }
> > #undef EXT_KEY
> > }
>
> I'd prefer that to be done after removing the "if
> (has_vector()/has_fpu()) by using the .validate callback for ISA
> extension. This way, you'll have only a single commit reordering everything.
Right, and I do have some WIP for that here
https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/log/?h=validate_fpu_and_vector
but won't be sending that until it's cleaned up after the merge window.
I was intentionally sending this during it so that there would be no
moving pieces for this to conflict with - because it will conflict with
any other patch adding things to the list tails.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-07-17 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 8:54 [PATCH v1] RISC-V: hwprobe: sort EXT_KEY()s in hwprobe_isa_ext0() alphabetically Conor Dooley
2024-07-17 13:34 ` Clément Léger
2024-07-17 13:42 ` Conor Dooley [this message]
2024-07-17 13:47 ` Clément Léger
2024-07-23 12:58 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240717-unluckily-collide-1aa35c97662c@spud \
--to=conor@kernel.org \
--cc=cleger@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox