Re: [PATCH v12 48/84] KVM: Move x86's API to release a faultin page to common KVM

Paolo Bonzini
2024-07-31T11:30:50Z

On 7/30/24 21:15, Sean Christopherson wrote:
>> Does it make sense to move RET_PF_* to common code, and avoid a bool
>> argument here?
> After this series, probably? Especially if/when we make "struct kvm_page_fault"
> a common structure and converge all arch code. In this series, definitely not,
> as it would require even more patches to convert other architectures, and it's
> not clear that it would be a net win, at least not without even more massaging.

It does not seem to be hard, but I agree that all the other
architectures right now use 0/-errno in the callers of
kvm_release_faultin_page().

Paolo