From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E51DC3DA64 for ; Wed, 31 Jul 2024 08:12:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sHSSOGXfJR7QbIcBpIFvAy2R0wdNBtRPFPq9Zm2TDeg=; b=nbAj1ZeAwtjVGd 9qawOYCG0ZG6F4WM4gWzOIhKbRQDHIRWd6ZukPgWwITmT7em5RJio1VZkELcr1MQR5rjkZadfzZg9 9rPxSmfl5LAwD1hX7V8DQy4nST7cn1zYfK7U9uAfHj+ClgwoYdUVSHwrB5KHiA+z73kuEu8dTXtt+ enRqNzQ5hDXpjUjWQEtcJieZ+s9OgAnUYtO3VZdRD4M0iaJt5bUCU85CQ6obKa2puQGuFtas1mYHg W8p2+uSx3J1IL2RMKONkBAi/bo8XJvpmW+x/Bz5PQnAl/EHnoJiMs6vFnRrSZrZhK8FU/l8o7QJwB M9A5vVpJhW1aE4CPsbyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZ4Rq-00000000GmQ-3dDZ; Wed, 31 Jul 2024 08:12:38 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZ4Rm-00000000GjH-0rYB for linux-riscv@lists.infradead.org; Wed, 31 Jul 2024 08:12:36 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5a15c2dc569so4762093a12.3 for ; Wed, 31 Jul 2024 01:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1722413552; x=1723018352; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bPhqvXPcxjB8hmfad49hCHGbmNQ9dpteVou05ijuxXo=; b=VMEenS+ckueFiLrUs6Ho76Ib3brjcJodwfm99HnBlqfYvmUMGWyRx1XglGNR8n+7bB HQiBrOX+z3o7wl2V5ojwY+30IOIbFlGJZbH0lPPOGdwmnPC6/0q1ndgCDnKGCqUJSltz 4zoghlQ9Pu+29Jgo3kZA/elQh4AEfP8U2CjlPm7kjAJtuM6agyccZ6F5Z41623jraCu/ /dOQxuAAp2k5QSUUTQ2XHaYpBiziGz1PFIzGWqtrTwPanbvzlqnR6n/QqHS8CgW+WtwR 9PGPSsRij9mEJ4VFV0tv1RaY8uFbtPB4HiLVun9ZKk+6WOgG0TY755RGP3HrgR3ajno2 qUNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722413552; x=1723018352; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bPhqvXPcxjB8hmfad49hCHGbmNQ9dpteVou05ijuxXo=; b=eZXAlwjBkbcRC46dUuZG2NDO7l2rFYyeT2yiNWhnZw4wGkWhD5D54uxrm1jgyIYk8K cao8se1KyRMzf0GMdctIcoSiZIAf57wTm3rCrdaIney5+QMlgwKGVJWhv9VLTU6dgpCL 1cIUYNS8qedv/JEzSF6zP9XxmmkP6sWwYxp+dtzo3DGV/jwjq18EvvtgeGjFBxWMEaLA ruJeqylPs2kwg1hAP5P2vuXR0IRx6QW1FKOVKqykUMnGYwEdDDOHe0ig5wuB7O3k0E8k 16zoe4imvfgtjZxTX5UAWF7m3yXJL6Sh/m9A6Tjn2hoNk+6EPZFFQtcTHqKsq/ZZUaZC 2T8Q== X-Forwarded-Encrypted: i=1; AJvYcCXBCV88V3g0QeQmJ4+089XkadRilrF5PFqg/GjMOb4Tor8pHMVXpSsL9E8hKxd20VGAjzAjkrQPMjY3zo7vpcaobPKDFJyDgWWF+uOTO7FZ X-Gm-Message-State: AOJu0YzcbkpXd8QjZqgUiB6a2xdGoXG6jIr7wo2+YWlOSfYKnfD1dSbi OacVux30nB/cz59uCmYnGED6NF7Xum4CL07DspRB1ubmvAbBsPdvK8KvSBITkno= X-Google-Smtp-Source: AGHT+IGxlRCnb+W6DiXG7nTnr6lyiGJnx0i1YWV+5ADomMCnBj37OyG82iPSl5g4jXJI8y3klQMjSg== X-Received: by 2002:a50:d7c1:0:b0:57d:3df:f881 with SMTP id 4fb4d7f45d1cf-5b021190495mr11744615a12.3.1722413552263; Wed, 31 Jul 2024 01:12:32 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac60918cb4sm8394451a12.0.2024.07.31.01.12.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 01:12:31 -0700 (PDT) Date: Wed, 31 Jul 2024 10:12:31 +0200 From: Andrew Jones To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , David Stevens Subject: Re: [PATCH v12 57/84] KVM: RISC-V: Mark "struct page" pfns accessed before dropping mmu_lock Message-ID: <20240731-f034f3516f0fffede877c68d@orel> References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-58-seanjc@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240726235234.228822-58-seanjc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_011234_359303_818868EC X-CRM114-Status: GOOD ( 15.64 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Jul 26, 2024 at 04:52:06PM GMT, Sean Christopherson wrote: > Mark pages accessed before dropping mmu_lock when faulting in guest memory > so that RISC-V can convert to kvm_release_faultin_page() without tripping > its lockdep assertion on mmu_lock being held. Marking pages accessed > outside of mmu_lock is ok (not great, but safe), but marking pages _dirty_ > outside of mmu_lock can make filesystems unhappy. > > Signed-off-by: Sean Christopherson > --- > arch/riscv/kvm/mmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c > index 06aa5a0d056d..806f68e70642 100644 > --- a/arch/riscv/kvm/mmu.c > +++ b/arch/riscv/kvm/mmu.c > @@ -683,10 +683,10 @@ int kvm_riscv_gstage_map(struct kvm_vcpu *vcpu, > out_unlock: > if ((!ret || ret == -EEXIST) && writable) > kvm_set_pfn_dirty(hfn); > + else > + kvm_release_pfn_clean(hfn); > > spin_unlock(&kvm->mmu_lock); > - kvm_set_pfn_accessed(hfn); > - kvm_release_pfn_clean(hfn); > return ret; > } > > -- > 2.46.0.rc1.232.g9752f9e123-goog > Reviewed-by: Andrew Jones _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv