Re: [PATCH v3 03/26] MIPS: sgi-ip27: ensure node_possible_map only contains valid nodes

Jonathan Cameron
2024-08-01T17:45:40Z

On Thu, 1 Aug 2024 09:08:03 +0300
Mike Rapoport <rppt@kernel.org> wrote:

> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>
> For SGI IP27 machines node_possible_map is statically set to
> NODE_MASK_ALL and it is not updated during NUMA initialization.
>
> Ensure that it only contains nodes present in the system.
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
> arch/mips/sgi-ip27/ip27-smp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/sgi-ip27/ip27-smp.c b/arch/mips/sgi-ip27/ip27-smp.c
> index 5d2652a1d35a..62733e049570 100644
> --- a/arch/mips/sgi-ip27/ip27-smp.c
> +++ b/arch/mips/sgi-ip27/ip27-smp.c
> @@ -70,11 +70,13 @@ void cpu_node_probe(void)
> gda_t *gdap = GDA;
>
> nodes_clear(node_online_map);
> + nodes_clear(node_possible_map);
> for (i = 0; i < MAX_NUMNODES; i++) {
> nasid_t nasid = gdap->g_nasidtable[i];
> if (nasid == INVALID_NASID)
> break;
> node_set_online(nasid);
> + node_set(nasid, node_possible_map);
> highest = node_scan_cpus(nasid, highest);
> }