From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1134FCFB445 for ; Mon, 7 Oct 2024 09:30:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H95mfHobmc2iaAwq1xpc5HX8dBKEjMGrL4bUTeYw/Js=; b=TY9SN/8RT9olwz tCe8RPbQeB26yWlMMKm/NXj4rrywI0H5cYD2QnKnfmHMQLv6LfRqruCTYyJ/Za//+m9TF40ke6Ink bRcWoTWEM6BXKOd1ulFR3vvDbJpoGCMyKmB0AEXvxaLpdkFa6XK+7xBkyz5zq2CJ5J+iVHmlFWkOF uBDYLEYdDo9yVaUjop4qlaXWxbjTePhhBlPjttCYApvsMgA4TN7AW+CmiC6tT9eWi9dx6EAXSJxGk SSrb9B4V/pFfhm2ibE82/xwDE+DSS0Jg1lWZPcOr0qYy5S1Kurzs+v1GKvKTwldGbjb4ER/aNpBe/ mXSBo+hHEMdZTdYm74Zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxk4V-00000001uca-39eg; Mon, 07 Oct 2024 09:30:31 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sxiyC-00000001iyT-1ZEy; Mon, 07 Oct 2024 08:20:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CEFA55C57AC; Mon, 7 Oct 2024 08:19:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C0EBC4CEC6; Mon, 7 Oct 2024 08:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728289193; bh=p7fnPdg9GXFJITuQrseQDNuIaX+4R+NIr2XuOdnxTOg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=on0X8S+1tuhId3VGYt/LSW/vWZbtRu4Y0aAQW8QemIGTVE/BdqBPjbVf5qr/sVgrV qEdd2OyD6z9TcgrMmY+8Oh7g2d+1vNz1XqHjtvgqVMrJRT93O3sfn4SRuiX7MeZIyN oB4RDp1mbFMnnskliJcMyp9o6WSW/8hvbpVcvMg31JDfURhR0DNt9+x/2tK/+KbI48 1blKwBDXXHuRTLpJc03VfTGnPuqY6j34ToTWoxjjhHN1tP5wKC95lPFzGiYf6Yydjm zr+iik+uEgMQJDBUkplHIdEc4ElZ8TzU9C7pGLb16/zTWSZbzxehCxXdDKA2+A1d91 DEzwPUTTfYNqw== Date: Mon, 7 Oct 2024 17:19:42 +0900 From: Masami Hiramatsu (Google) To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nick Terrell , "Steven Rostedt (Google)" , Guilherme Amadio , Changbin Du , Daniel Bristot de Oliveira , Daniel Wagner , Aditya Gupta , Athira Rajeev , Masahiro Yamada , Kajol Jain , Huacai Chen , Bibo Mao , Anup Patel , Atish Patra , Shenlin Liang , Oliver Upton , "Steinar H. Gunderson" , "Dr. David Alan Gilbert" , Chen Pei , Dima Kogan , Yury Norov , Alexander Lobakin , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 19/31] perf arm64: Remove dwarf-regs.c Message-Id: <20241007171942.e96d5c520e065bbe4cf8ae5f@kernel.org> In-Reply-To: <20241005195541.380070-20-irogers@google.com> References: <20241005195541.380070-1-irogers@google.com> <20241005195541.380070-20-irogers@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_011958_710884_8162EEAE X-CRM114-Status: GOOD ( 25.57 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sat, 5 Oct 2024 12:55:29 -0700 Ian Rogers wrote: > The file just provides the function get_arch_regstr, however, if in > the only caller get_dwarf_regstr EM_HOST is used for the EM_NONE case > the function can never be called. So remove as dead code. Tidy up the > EM_NONE cases for arm64 in dwarf-regs.c. OK, this seems just a redundant information in tools/perf/arch/arm64/include/dwarf-regs-table.h (there is alredy register number -> name mapping table.) Looks good to me. Acked-by: Masami Hiramatsu (Google) Thank you, > > Signed-off-by: Ian Rogers > --- > tools/perf/arch/arm64/util/Build | 1 - > tools/perf/arch/arm64/util/dwarf-regs.c | 80 ------------------------- > tools/perf/util/dwarf-regs.c | 4 +- > tools/perf/util/include/dwarf-regs.h | 2 +- > 4 files changed, 3 insertions(+), 84 deletions(-) > delete mode 100644 tools/perf/arch/arm64/util/dwarf-regs.c > > diff --git a/tools/perf/arch/arm64/util/Build b/tools/perf/arch/arm64/util/Build > index 4387a6d6a6c3..a74521b79eaa 100644 > --- a/tools/perf/arch/arm64/util/Build > +++ b/tools/perf/arch/arm64/util/Build > @@ -4,7 +4,6 @@ perf-util-y += perf_regs.o > perf-util-y += tsc.o > perf-util-y += pmu.o > perf-util-$(CONFIG_LIBTRACEEVENT) += kvm-stat.o > -perf-util-$(CONFIG_LIBDW) += dwarf-regs.o > perf-util-$(CONFIG_LOCAL_LIBUNWIND) += unwind-libunwind.o > perf-util-$(CONFIG_LIBDW_DWARF_UNWIND) += unwind-libdw.o > > diff --git a/tools/perf/arch/arm64/util/dwarf-regs.c b/tools/perf/arch/arm64/util/dwarf-regs.c > deleted file mode 100644 > index 343a62fa4199..000000000000 > --- a/tools/perf/arch/arm64/util/dwarf-regs.c > +++ /dev/null > @@ -1,80 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0-only > -/* > - * Mapping of DWARF debug register numbers into register names. > - * > - * Copyright (C) 2010 Will Deacon, ARM Ltd. > - */ > - > -#include > -#include > -#include > -#include > -#include > - > -struct regs_dwarfnum { > - const char *name; > - unsigned int dwarfnum; > -}; > - > -#define REG_DWARFNUM_NAME(r, num) {.name = r, .dwarfnum = num} > -#define GPR_DWARFNUM_NAME(num) \ > - {.name = __stringify(%x##num), .dwarfnum = num} > -#define REG_DWARFNUM_END {.name = NULL, .dwarfnum = 0} > - > -/* > - * Reference: > - * http://infocenter.arm.com/help/topic/com.arm.doc.ihi0057b/IHI0057B_aadwarf64.pdf > - */ > -static const struct regs_dwarfnum regdwarfnum_table[] = { > - GPR_DWARFNUM_NAME(0), > - GPR_DWARFNUM_NAME(1), > - GPR_DWARFNUM_NAME(2), > - GPR_DWARFNUM_NAME(3), > - GPR_DWARFNUM_NAME(4), > - GPR_DWARFNUM_NAME(5), > - GPR_DWARFNUM_NAME(6), > - GPR_DWARFNUM_NAME(7), > - GPR_DWARFNUM_NAME(8), > - GPR_DWARFNUM_NAME(9), > - GPR_DWARFNUM_NAME(10), > - GPR_DWARFNUM_NAME(11), > - GPR_DWARFNUM_NAME(12), > - GPR_DWARFNUM_NAME(13), > - GPR_DWARFNUM_NAME(14), > - GPR_DWARFNUM_NAME(15), > - GPR_DWARFNUM_NAME(16), > - GPR_DWARFNUM_NAME(17), > - GPR_DWARFNUM_NAME(18), > - GPR_DWARFNUM_NAME(19), > - GPR_DWARFNUM_NAME(20), > - GPR_DWARFNUM_NAME(21), > - GPR_DWARFNUM_NAME(22), > - GPR_DWARFNUM_NAME(23), > - GPR_DWARFNUM_NAME(24), > - GPR_DWARFNUM_NAME(25), > - GPR_DWARFNUM_NAME(26), > - GPR_DWARFNUM_NAME(27), > - GPR_DWARFNUM_NAME(28), > - GPR_DWARFNUM_NAME(29), > - REG_DWARFNUM_NAME("%lr", 30), > - REG_DWARFNUM_NAME("%sp", 31), > - REG_DWARFNUM_END, > -}; > - > -/** > - * get_arch_regstr() - lookup register name from it's DWARF register number > - * @n: the DWARF register number > - * > - * get_arch_regstr() returns the name of the register in struct > - * regdwarfnum_table from it's DWARF register number. If the register is not > - * found in the table, this returns NULL; > - */ > -const char *get_arch_regstr(unsigned int n) > -{ > - const struct regs_dwarfnum *roff; > - > - for (roff = regdwarfnum_table; roff->name != NULL; roff++) > - if (roff->dwarfnum == n) > - return roff->name; > - return NULL; > -} > diff --git a/tools/perf/util/dwarf-regs.c b/tools/perf/util/dwarf-regs.c > index eac99a246737..18e916c8e993 100644 > --- a/tools/perf/util/dwarf-regs.c > +++ b/tools/perf/util/dwarf-regs.c > @@ -32,14 +32,14 @@ > const char *get_dwarf_regstr(unsigned int n, unsigned int machine, > unsigned int flags __maybe_unused) > { > -#if EM_HOST == EM_X86_64 || EM_HOST == EM_386 > +#if EM_HOST == EM_X86_64 || EM_HOST == EM_386 || EM_HOST == EM_AARCH64 > if (machine == EM_NONE) { > /* Generic arch - use host arch */ > machine = EM_HOST; > } > #endif > switch (machine) { > -#if EM_HOST != EM_X86_64 && EM_HOST != EM_386 > +#if EM_HOST != EM_X86_64 && EM_HOST != EM_386 && EM_HOST != EM_AARCH64 > case EM_NONE: /* Generic arch - use host arch */ > return get_arch_regstr(n); > #endif > diff --git a/tools/perf/util/include/dwarf-regs.h b/tools/perf/util/include/dwarf-regs.h > index 062623aefd5a..e640657f69c8 100644 > --- a/tools/perf/util/include/dwarf-regs.h > +++ b/tools/perf/util/include/dwarf-regs.h > @@ -79,7 +79,7 @@ > #define DWARF_REG_FB 0xd3affb /* random number */ > > #ifdef HAVE_LIBDW_SUPPORT > -#if !defined(__x86_64__) && !defined(__i386__) > +#if !defined(__x86_64__) && !defined(__i386__) && !defined(__aarch64__) > const char *get_arch_regstr(unsigned int n); > #endif > > -- > 2.47.0.rc0.187.ge670bccf7e-goog > -- Masami Hiramatsu (Google) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv