Re: [PATCH] kernel/irq/proc: performance: replace seq_printf with seq_put_decimal_ull_width

David Wang
2024-11-08T16:32:11Z

Hi,

At 2024-11-08 22:25:13, "Thomas Gleixner" <tglx@linutronix.de> wrote:
>David!
>
>On Sun, Nov 03 2024 at 16:05, David Wang wrote:
>
>$Subject: [PATCH] kernel/irq/proc: performance: ...
>
>That's not a valid subsystem prefix.

copy that~

>
>> seq_printf is costy, when stress reading /proc/interrupts, profiling indicates
>> seq_printf takes about ~47% of show_interrupts samples:
>
>Also please follow the documentation for denoting functions in change
>logs:
>
>https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#function-references-in-changelogs
>

copy that~

>> arch/alpha/kernel/irq.c | 8 +--
>> arch/arm/kernel/smp.c | 4 +-
>> arch/arm64/kernel/smp.c | 3 +-
>> arch/csky/kernel/smp.c | 4 +-
>> arch/loongarch/kernel/smp.c | 2 +-
>> arch/parisc/kernel/irq.c | 34 ++++++------
>> arch/powerpc/kernel/irq.c | 44 ++++++++--------
>> arch/riscv/kernel/smp.c | 3 +-
>> arch/sh/kernel/irq.c | 4 +-
>> arch/sparc/kernel/irq_32.c | 12 ++---
>> arch/sparc/kernel/irq_64.c | 4 +-
>> arch/x86/kernel/irq.c | 100 ++++++++++++++++++------------------
>> arch/xtensa/kernel/irq.c | 2 +-
>> arch/xtensa/kernel/smp.c | 4 +-
>> kernel/irq/proc.c | 6 ++-
>
>There is no dependency on these changes. So please split them up into
>seperate patches for core and the individual architectures.an

Thanks for all the review, I will make a patchset for this.
>
>Thanks,
>
> tglx

David