From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E840AD5D699 for ; Fri, 8 Nov 2024 00:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dh82YCfy4jFlFqwcFNE2kHhfYKtpMkTAcZmBlQWnmaE=; b=tUDkMI6wruYoXn MtS1jOel+EdtHbrQXzu9RHXpyed4O5h+KBPB84n38+wHbw23iNXWgClSkPRwRpJO6pqLTczKaQbU1 YoWvke7J0icafLTDzHo2XikbOcFh7PJWYdvXHm6LPjk66JIGsH9KzRSIIa+aHj1ANctW4Tjb2U0FV 0lqyR6KKTucPHD1IbeYES88LlA9pD2RidsFo3L/myPbTIXX2nDAZWxhLBo8p9BlrWdqxYZ3pi0V3E 0xvrrhCSC+SjrTPx/kKd/DqpQtAmV6WjHCZZR0eCRv02uaBPuUsGxt68w31CgqS88ZJYQlZ43VbkV 1zE+wnaboroT/Gq/WSDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t9CSZ-00000008nUF-0GH5; Fri, 08 Nov 2024 00:02:43 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t9CQk-00000008nFW-48a3; Fri, 08 Nov 2024 00:00:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9C5A35C5698; Fri, 8 Nov 2024 00:00:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75D47C4CECC; Fri, 8 Nov 2024 00:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731024048; bh=A1nYBKBjEzWsfHtk4DuraLYhFByKzZ3xxQIgXdcE7YI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dgK1c0Gx3JpYWiutgr99uTMw0ppxTTMR2JvkRft+iLbbm+nBkVyoMxX9/SUayeOOq /B5ASGXVaOfZG4Xk2pNHYZVz57FCko1MojjWS6hHDsD/XEuBhwP3M7DVOFdZ2zEFjn T6kt6y7ivMNeo2Mhg2/dxlYoL3T62gFBnCzabCVEqoB5+hmPraY6InKaGcyPcDGP6q OcX34Y06SCEtysIq+D20N/6GvPF3s+095pzROJcYQqd7jtn8M5bPERxS/tODNTcGE0 zkbLpazUOSouCV24V6po8NmwVq0CpQitrRu/1IvBUWiRg89D1jk1Tcu+8wO10sR5HN Kxl9ki5avSVtw== Date: Fri, 8 Nov 2024 09:00:40 +0900 From: Masami Hiramatsu (Google) To: Namhyung Kim Cc: Ian Rogers , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nick Terrell , Changbin Du , Guilherme Amadio , Yang Jihong , Aditya Gupta , Athira Rajeev , Masahiro Yamada , Bibo Mao , Huacai Chen , Kajol Jain , Atish Patra , Shenlin Liang , Anup Patel , Oliver Upton , "Steinar H. Gunderson" , "Dr. David Alan Gilbert" , Chen Pei , Dima Kogan , Przemek Kitszel , "David S. Miller" , Alexander Lobakin , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 00/20] Remove PERF_HAVE_DWARF_REGS Message-Id: <20241108090040.463cb3f0820e7ac22d1bb6c2@kernel.org> In-Reply-To: References: <20241017002520.59124-1-irogers@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241107_160051_146449_0ABEE1DF X-CRM114-Status: GOOD ( 37.55 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi, On Thu, 7 Nov 2024 11:29:34 -0800 Namhyung Kim wrote: > Hi all, > > On Wed, Oct 16, 2024 at 05:25:00PM -0700, Ian Rogers wrote: > > These changes are on top of: > > https://lore.kernel.org/lkml/20241017001354.56973-1-irogers@google.com/ > > > > Prior to these patches PERF_HAVE_DWARF_REGS indicated the presence of > > dwarf-regs.c in the arch directory. dwarf-regs.c provided upto 4 > > functions: > > > > 1) regs_query_register_offset would translate a register name into a > > pt_regs offset and was used by BPF prologues. BPF prologues existed > > for BPF events and support for these was removed many releases ago. > > This code was dead and could be removed. > > > > 2) get_arch_regstr duplicated get_dwarf_regstr and so it could be > > removed. The case for csky was a little more complicated as the ABI > > controlled the string. The callers of get_dwarf_regstr were updated to > > also pass the ELF flags so that on csky the ABI appropriate table > > could be used. As the argument is only used on csky this a no-op for > > everything else. > > > > 3) get_arch_regnum translated a register name back to a dwarf number > > and only existed on x86 where "al", "ax", "eax" and "rax" could all > > mean register 0. This code was moved to util with similar > > machine/flags logic to get_arch_regstr and for consistency with it. > > > > 4) get_powerpc_regs a PowerPC specific function used by annotate that > > should really be in util. > > > > 2 and 3 required the wiring through of the ELF machine and flags in > > callers to get_dwarf_regstr and get_dwarf_regnum. When these values > > weren't dependent on an ELF file a new EM_HOST and EF_HOST were added > > to give the host ELF machine and flags. These 2 #defines got rid of > > the existing separate arch files and #ifdefs. > > > > v3: These files were separated from the rest of the v2 libdw clean up > > in: > > https://lore.kernel.org/lkml/CAP-5=fVZH3L-6y_sxLwSmT8WyMXDMFnuqUksNULdQYJCPNBFYw@mail.gmail.com/ > > > > Ian Rogers (20): > > perf bpf-prologue: Remove unused file > > perf dwarf-regs: Remove PERF_HAVE_ARCH_REGS_QUERY_REGISTER_OFFSET > > perf dwarf-regs: Add EM_HOST and EF_HOST defines > > perf disasm: Add e_machine/e_flags to struct arch > > perf dwarf-regs: Pass accurate disassembly machine to get_dwarf_regnum > > perf dwarf-regs: Pass ELF flags to get_dwarf_regstr > > perf dwarf-regs: Move x86 dwarf-regs out of arch > > perf arm64: Remove dwarf-regs.c > > perf arm: Remove dwarf-regs.c > > perf dwarf-regs: Move csky dwarf-regs out of arch > > perf loongarch: Remove dwarf-regs.c > > perf mips: Remove dwarf-regs.c > > perf dwarf-regs: Move powerpc dwarf-regs out of arch > > perf riscv: Remove dwarf-regs.c and add dwarf-regs-table.h > > perf s390: Remove dwarf-regs.c > > perf sh: Remove dwarf-regs.c > > perf sparc: Remove dwarf-regs.c > > perf xtensa: Remove dwarf-regs.c > > perf dwarf-regs: Remove get_arch_regstr code > > perf build: Remove PERF_HAVE_DWARF_REGS > > These look all good and I'm about to apply the series. > > Masami, do you have any remaining concerns? It'd be nice if you can > give your Reviewed-by. I think it looks good to me. Reviewed-by: Masami Hiramatsu (Google) Thank you, > > Thanks, > Namhyug > > > > > tools/perf/Makefile.config | 17 +- > > tools/perf/arch/arc/annotate/instructions.c | 2 + > > tools/perf/arch/arm/Makefile | 3 - > > tools/perf/arch/arm/annotate/instructions.c | 2 + > > tools/perf/arch/arm/util/Build | 2 - > > tools/perf/arch/arm/util/dwarf-regs.c | 61 ------- > > tools/perf/arch/arm64/Makefile | 4 - > > tools/perf/arch/arm64/annotate/instructions.c | 2 + > > tools/perf/arch/arm64/util/Build | 1 - > > tools/perf/arch/arm64/util/dwarf-regs.c | 92 ----------- > > tools/perf/arch/csky/Makefile | 4 - > > tools/perf/arch/csky/annotate/instructions.c | 7 +- > > tools/perf/arch/csky/util/Build | 1 - > > tools/perf/arch/loongarch/Makefile | 4 - > > .../arch/loongarch/annotate/instructions.c | 2 + > > tools/perf/arch/loongarch/util/Build | 1 - > > tools/perf/arch/loongarch/util/dwarf-regs.c | 44 ----- > > tools/perf/arch/mips/Makefile | 4 - > > tools/perf/arch/mips/annotate/instructions.c | 2 + > > tools/perf/arch/mips/util/Build | 1 - > > tools/perf/arch/mips/util/dwarf-regs.c | 38 ----- > > tools/perf/arch/powerpc/Makefile | 5 - > > .../perf/arch/powerpc/annotate/instructions.c | 2 + > > tools/perf/arch/powerpc/util/Build | 1 - > > tools/perf/arch/powerpc/util/dwarf-regs.c | 153 ------------------ > > tools/perf/arch/riscv/Makefile | 5 +- > > .../arch/riscv/include/dwarf-regs-table.h | 42 +++++ > > tools/perf/arch/riscv/util/Build | 1 - > > tools/perf/arch/riscv/util/dwarf-regs.c | 72 --------- > > .../perf/arch/riscv64/annotate/instructions.c | 2 + > > tools/perf/arch/s390/Makefile | 4 - > > tools/perf/arch/s390/annotate/instructions.c | 2 + > > tools/perf/arch/s390/util/Build | 1 - > > tools/perf/arch/s390/util/dwarf-regs.c | 43 ----- > > tools/perf/arch/sh/Build | 1 - > > tools/perf/arch/sh/Makefile | 4 - > > tools/perf/arch/sh/util/Build | 1 - > > tools/perf/arch/sh/util/dwarf-regs.c | 41 ----- > > tools/perf/arch/sparc/Build | 1 - > > tools/perf/arch/sparc/Makefile | 4 - > > tools/perf/arch/sparc/annotate/instructions.c | 2 + > > tools/perf/arch/sparc/util/Build | 1 - > > tools/perf/arch/sparc/util/dwarf-regs.c | 39 ----- > > tools/perf/arch/x86/Makefile | 4 - > > tools/perf/arch/x86/annotate/instructions.c | 3 +- > > tools/perf/arch/x86/util/Build | 3 - > > tools/perf/arch/x86/util/dwarf-regs.c | 153 ------------------ > > tools/perf/arch/xtensa/Build | 1 - > > tools/perf/arch/xtensa/Makefile | 4 - > > tools/perf/arch/xtensa/util/Build | 1 - > > tools/perf/arch/xtensa/util/dwarf-regs.c | 21 --- > > tools/perf/util/Build | 3 + > > tools/perf/util/annotate.c | 6 +- > > tools/perf/util/bpf-prologue.h | 37 ----- > > tools/perf/util/disasm.h | 4 + > > .../dwarf-regs.c => util/dwarf-regs-csky.c} | 19 +-- > > tools/perf/util/dwarf-regs-powerpc.c | 61 +++++++ > > tools/perf/util/dwarf-regs-x86.c | 50 ++++++ > > tools/perf/util/dwarf-regs.c | 38 +++-- > > tools/perf/util/include/dwarf-regs.h | 110 ++++++++++--- > > tools/perf/util/probe-finder.c | 13 +- > > tools/perf/util/probe-finder.h | 3 +- > > 62 files changed, 328 insertions(+), 927 deletions(-) > > delete mode 100644 tools/perf/arch/arm/util/dwarf-regs.c > > delete mode 100644 tools/perf/arch/arm64/util/dwarf-regs.c > > delete mode 100644 tools/perf/arch/csky/Makefile > > delete mode 100644 tools/perf/arch/loongarch/util/dwarf-regs.c > > delete mode 100644 tools/perf/arch/mips/util/dwarf-regs.c > > delete mode 100644 tools/perf/arch/powerpc/util/dwarf-regs.c > > create mode 100644 tools/perf/arch/riscv/include/dwarf-regs-table.h > > delete mode 100644 tools/perf/arch/riscv/util/dwarf-regs.c > > delete mode 100644 tools/perf/arch/s390/util/dwarf-regs.c > > delete mode 100644 tools/perf/arch/sh/Build > > delete mode 100644 tools/perf/arch/sh/Makefile > > delete mode 100644 tools/perf/arch/sh/util/Build > > delete mode 100644 tools/perf/arch/sh/util/dwarf-regs.c > > delete mode 100644 tools/perf/arch/sparc/Build > > delete mode 100644 tools/perf/arch/sparc/util/Build > > delete mode 100644 tools/perf/arch/sparc/util/dwarf-regs.c > > delete mode 100644 tools/perf/arch/x86/util/dwarf-regs.c > > delete mode 100644 tools/perf/arch/xtensa/Build > > delete mode 100644 tools/perf/arch/xtensa/Makefile > > delete mode 100644 tools/perf/arch/xtensa/util/Build > > delete mode 100644 tools/perf/arch/xtensa/util/dwarf-regs.c > > delete mode 100644 tools/perf/util/bpf-prologue.h > > rename tools/perf/{arch/csky/util/dwarf-regs.c => util/dwarf-regs-csky.c} (74%) > > create mode 100644 tools/perf/util/dwarf-regs-powerpc.c > > create mode 100644 tools/perf/util/dwarf-regs-x86.c > > > > -- > > 2.47.0.105.g07ac214952-goog > > -- Masami Hiramatsu (Google) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv