Re: [RFC PATCH 08/15] iommu/riscv: Add IRQ domain for interrupt remapping

Jason Gunthorpe
2024-11-18T18:43:47Z

On Thu, Nov 14, 2024 at 05:18:53PM +0100, Andrew Jones wrote:
> @@ -1276,10 +1279,30 @@ static int riscv_iommu_attach_paging_domain(struct iommu_domain *iommu_domain,
> struct riscv_iommu_device *iommu = dev_to_iommu(dev);
> struct riscv_iommu_info *info = dev_iommu_priv_get(dev);
> struct riscv_iommu_dc dc = {0};
> + int ret;
>
> if (!riscv_iommu_pt_supported(iommu, domain->pgd_mode))
> return -ENODEV;
>
> + if (riscv_iommu_bond_link(domain, dev))
> + return -ENOMEM;
> +
> + if (iommu_domain->type == IOMMU_DOMAIN_UNMANAGED) {

Drivers should not be making tests like this.

> + domain->gscid = ida_alloc_range(&riscv_iommu_gscids, 1,
> + RISCV_IOMMU_MAX_GSCID, GFP_KERNEL);
> + if (domain->gscid < 0) {
> + riscv_iommu_bond_unlink(domain, dev);
> + return -ENOMEM;
> + }
> +
> + ret = riscv_iommu_irq_domain_create(domain, dev);
> + if (ret) {
> + riscv_iommu_bond_unlink(domain, dev);
> + ida_free(&riscv_iommu_gscids, domain->gscid);
> + return ret;
> + }
> + }

What are you trying to do? Make something behave different for VFIO?
That isn't OK, we are trying to remove all the hacky VFIO special
cases in drivers.

What is the HW issue here? It is very very strange (and probably not
going to work right) that the irq domains change when domain
attachment changes.

The IRQ setup should really be fixed before any device drivers probe
onto the device.

Jason