From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5866AD69112 for ; Thu, 28 Nov 2024 14:16:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:CC:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fguDaXzhL2HNyUnuA+QOuXlwbHhF8Wl/PErzQWeOFwY=; b=PPpmFXt3wDpbjCQXG19ykh2e8u SbieecFszPpNE3xRVhwwXwQCv1arAVTVFkyMzaYCXBngyT8+rVyVx0GdXgPzG2au1FQqH7zn/1ZrC RAqh5cas8Gt97Hg9jIKZQdhKYM6TAkS69/Hv90/EwwFEIOBlpww8ljf6ej9NmUDE2g1lW7Svioyke Zv/gQXTV71EHnZxMnd8/XAX0kKccFpMkA8tjgWFCl8n8dcjxof53fcBSQ7Z3kwbnWN8wH+XNZdk/q ybvwj8vBzr7+JBUENlM0XvuHEXlzccZRhniibpOOdt8f0TnL74l6A50ldEjw0xUgoa+BnPwVFYG00 Abrna0ig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tGfJE-0000000Fjnf-2R0k; Thu, 28 Nov 2024 14:15:56 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tGfJC-0000000FjmS-03do for linux-riscv@lists.infradead.org; Thu, 28 Nov 2024 14:15:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1732803355; x=1764339355; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VrsB10uMJv4ehZDB+SBDKh62wE2QLBRcfDmdTSQccCo=; b=Z+FHwySkBAXkVPVCjZW0o6NQMJmpaURrP80l5EoGSftrbzgUbTIl2HRg uF2wb4NuOnzYeBd/uMJt4Fd+6RCkTJ6j9rvsiwxhdnPCqBjUIq24k4sXC gb50ivvDwVa7ZyIqRkbHNYj04GemwkPPdyvfp8XTZORdJh4OPTn3rZRMv qJ/NK2OEJgImBkGLNtJMaf4a7rRDSESpmjm+wpC2U4IwxtsVKHIpBZPpj J3DxbEiujuupba4BgamVWSnE+hYHt3abQJm8GZCfc9bhjg7fVyyjisnf3 gaiE9ppQHJcAFd42wP7QvFo9sZycoTDvzuImb6CN1BpzGV6fXxxi2YtN9 Q==; X-CSE-ConnectionGUID: MOggi4BHRLiBwcWJ1t1VRg== X-CSE-MsgGUID: yQOBikyfSnq+HHysc3PPHg== X-IronPort-AV: E=Sophos;i="6.12,192,1728975600"; d="asc'?scan'208";a="266088084" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Nov 2024 07:15:53 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 28 Nov 2024 07:15:23 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 28 Nov 2024 07:15:20 -0700 Date: Thu, 28 Nov 2024 14:14:53 +0000 From: Conor Dooley To: Will Deacon CC: Alexandre Ghiti , Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Andrea Parri , Nathan Chancellor , Peter Zijlstra , Ingo Molnar , Waiman Long , Boqun Feng , Arnd Bergmann , Leonardo Bras , Guo Ren , , , , , Subject: Re: [PATCH v6 13/13] riscv: Add qspinlock support Message-ID: <20241128-uncivil-removed-4e105d1397c9@wendy> References: <20241103145153.105097-1-alexghiti@rivosinc.com> <20241103145153.105097-14-alexghiti@rivosinc.com> <20241128-whoever-wildfire-2a3110c5fd46@wendy> <20241128134135.GA3460@willie-the-truck> MIME-Version: 1.0 In-Reply-To: <20241128134135.GA3460@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241128_061554_116019_13AC98A8 X-CRM114-Status: GOOD ( 21.67 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1322779950163393585==" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org --===============1322779950163393585== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WBb/bzqDVTuERqKU" Content-Disposition: inline --WBb/bzqDVTuERqKU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 28, 2024 at 01:41:36PM +0000, Will Deacon wrote: > On Thu, Nov 28, 2024 at 12:56:55PM +0000, Conor Dooley wrote: > > On Sun, Nov 03, 2024 at 03:51:53PM +0100, Alexandre Ghiti wrote: > > > In order to produce a generic kernel, a user can select > > > CONFIG_COMBO_SPINLOCKS which will fallback at runtime to the ticket > > > spinlock implementation if Zabha or Ziccrse are not present. > > >=20 > > > Note that we can't use alternatives here because the discovery of > > > extensions is done too late and we need to start with the qspinlock > > > implementation because the ticket spinlock implementation would pollu= te > > > the spinlock value, so let's use static keys. > > >=20 > > > This is largely based on Guo's work and Leonardo reviews at [1]. > > >=20 > > > Link: https://lore.kernel.org/linux-riscv/20231225125847.2778638-1-gu= oren@kernel.org/ [1] > > > Signed-off-by: Guo Ren > > > Signed-off-by: Alexandre Ghiti > >=20 > > This patch (now commit ab83647fadae2 ("riscv: Add qspinlock support")) > > breaks boot on polarfire soc. It dies before outputting anything to the > > console. My .config has: > >=20 > > # CONFIG_RISCV_TICKET_SPINLOCKS is not set > > # CONFIG_RISCV_QUEUED_SPINLOCKS is not set > > CONFIG_RISCV_COMBO_SPINLOCKS=3Dy >=20 > I pointed out some of the fragility during review: >=20 > https://lore.kernel.org/all/20241111164259.GA20042@willie-the-truck/ >=20 > so I'm kinda surprised it got merged tbh :/ Maybe it could be reverted rather than having a broken boot with the default settings in -rc1. --WBb/bzqDVTuERqKU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZ0h63AAKCRB4tDGHoIJi 0qcjAQD1VYmRXRcmpfuKUiWAY8RvBFgoztaYktfbFy6aNPK3AQD+L2DsgGtQap0l /O61BvSrFDF+EyAogkoxnnR8R5f2Ag8= =tGkt -----END PGP SIGNATURE----- --WBb/bzqDVTuERqKU-- --===============1322779950163393585== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv --===============1322779950163393585==--