Re: [PATCH v3 2/3] dt-bindings: soc: spacemit: Add spacemit,k1-syscon

Krzysztof Kozlowski
2024-11-26T14:46:35Z

On 26/11/2024 15:31, Haylen Chu wrote:
> Add documentation to describe Spacemit K1 system controller registers.
>
> Signed-off-by: Haylen Chu <heylenay@4d2.org>
> ---
> .../soc/spacemit/spacemit,k1-syscon.yaml | 86 +++++++++++++++++++
> 1 file changed, 86 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml
> new file mode 100644
> index 000000000000..b9f20190a70a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml
> @@ -0,0 +1,86 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/spacemit/spacemit,k1-syscon.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Spacemit K1 SoC System Controller
> +
> +maintainers:
> + - Haylen Chu <heylenay@4d2.org>
> +
> +description:
> + The Spacemit K1 SoC system controller provides access to shared register files
> + for related SoC modules, such as clock controller and reset controller.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - spacemit,k1-apbc-syscon
> + - spacemit,k1-apbs-syscon
> + - spacemit,k1-apmu-syscon
> + - spacemit,k1-mpmu-syscon
> + - const: syscon
> + - const: simple-mfd
> +
> + reg:
> + maxItems: 1
> +
> + clock-controller:
> + $ref: /schemas/clock/spacemit,k1-ccu.yaml#
> + type: object
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 1
Nothing improved. That's a no-go.


This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.


Best regards,
Krzysztof