From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC355C282EC for ; Tue, 18 Mar 2025 05:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gDSfCdaU0883ebVZiNIZTLuPBeBs6PSQURkI58hDkL0=; b=s+f+ApbxQiszFB paE7sbAJI3BA5/zv6QQdSfo2+AceHupl7iTlyThPHf7djAt++KSO8PSSVm+kCSoRj+EqJYfI+TWzE NxiAfQG6OeDI+N4mIuJwQ7vSIsc27lhyk673qfMGlCX3ZO4ynkcQ8wLAexNQknBCFKbu8nd0J2zht HoX8AQI27bHGrNVAMPlEys73bvJtuwT/KkzQu7rCwwE5nszUdqv9rZpAN5uUZkbq7/6xk1DSHPPAN us/S52bNrN5QTCtBhAIt6Pt8RX/8blAG1XWDgbZybmVZi3SOFGeN819Koy0FSaHhgAPmAmSBVWe2R uS3dp2DQEmUMi+TVkSHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tuPe6-00000004jLT-2WUw; Tue, 18 Mar 2025 05:37:46 +0000 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tuPe3-00000004jL4-2N9P for linux-riscv@lists.infradead.org; Tue, 18 Mar 2025 05:37:44 +0000 Received: from localhost (unknown [116.232.18.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id 07985343249; Tue, 18 Mar 2025 05:37:40 +0000 (UTC) Date: Tue, 18 Mar 2025 05:37:36 +0000 From: Yixun Lan To: Haylen Chu Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Haylen Chu , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, spacemit@lists.linux.dev, Inochi Amaoto , Chen Wang , Jisheng Zhang , Meng Zhang Subject: Re: [PATCH v5 3/5] clk: spacemit: Add clock support for Spacemit K1 SoC Message-ID: <20250318053736-GYA2516@gentoo> References: <20250306175750.22480-2-heylenay@4d2.org> <20250306175750.22480-5-heylenay@4d2.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250306175750.22480-5-heylenay@4d2.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250317_223743_628780_88DDE73A X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Haylen Chu: On 17:57 Thu 06 Mar , Haylen Chu wrote: > The clock tree of K1 SoC contains three main types of clock hardware > (PLL/DDN/MIX) and has control registers split into several multifunction > devices: APBS (PLLs), MPMU, APBC and APMU. > > All register operations are done through regmap to ensure atomiciy > between concurrent operations of clock driver and reset, > power-domain driver that will be introduced in the future. > > Signed-off-by: Haylen Chu > --- > drivers/clk/Kconfig | 1 + > drivers/clk/Makefile | 1 + > drivers/clk/spacemit/Kconfig | 20 + > drivers/clk/spacemit/Makefile | 5 + > drivers/clk/spacemit/ccu-k1.c | 1714 +++++++++++++++++++++++++++++ > drivers/clk/spacemit/ccu_common.h | 47 + > drivers/clk/spacemit/ccu_ddn.c | 80 ++ > drivers/clk/spacemit/ccu_ddn.h | 48 + > drivers/clk/spacemit/ccu_mix.c | 284 +++++ > drivers/clk/spacemit/ccu_mix.h | 246 +++++ > drivers/clk/spacemit/ccu_pll.c | 146 +++ > drivers/clk/spacemit/ccu_pll.h | 76 ++ > 12 files changed, 2668 insertions(+) > create mode 100644 drivers/clk/spacemit/Kconfig > create mode 100644 drivers/clk/spacemit/Makefile > create mode 100644 drivers/clk/spacemit/ccu-k1.c > create mode 100644 drivers/clk/spacemit/ccu_common.h > create mode 100644 drivers/clk/spacemit/ccu_ddn.c > create mode 100644 drivers/clk/spacemit/ccu_ddn.h > create mode 100644 drivers/clk/spacemit/ccu_mix.c > create mode 100644 drivers/clk/spacemit/ccu_mix.h > create mode 100644 drivers/clk/spacemit/ccu_pll.c > create mode 100644 drivers/clk/spacemit/ccu_pll.h > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 713573b6c86c..19c1ed280fd7 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -517,6 +517,7 @@ source "drivers/clk/samsung/Kconfig" > source "drivers/clk/sifive/Kconfig" > source "drivers/clk/socfpga/Kconfig" > source "drivers/clk/sophgo/Kconfig" > +source "drivers/clk/spacemit/Kconfig" > source "drivers/clk/sprd/Kconfig" > source "drivers/clk/starfive/Kconfig" > source "drivers/clk/sunxi/Kconfig" > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile > index bf4bd45adc3a..42867cd37c33 100644 > --- a/drivers/clk/Makefile > +++ b/drivers/clk/Makefile > @@ -145,6 +145,7 @@ obj-$(CONFIG_COMMON_CLK_SAMSUNG) += samsung/ > obj-$(CONFIG_CLK_SIFIVE) += sifive/ > obj-y += socfpga/ > obj-y += sophgo/ > +obj-y += spacemit/ > obj-$(CONFIG_PLAT_SPEAR) += spear/ > obj-y += sprd/ > obj-$(CONFIG_ARCH_STI) += st/ > diff --git a/drivers/clk/spacemit/Kconfig b/drivers/clk/spacemit/Kconfig > new file mode 100644 > index 000000000000..76090cd85668 > --- /dev/null > +++ b/drivers/clk/spacemit/Kconfig > @@ -0,0 +1,20 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +config SPACEMIT_CCU > + tristate "Clock support for Spacemit SoCs" > + default y similar reason to pinctrl with these patches [1], [2] I'd suggest switch to "bool + default ARCH_SPACEMIT" Link: https://lore.kernel.org/all/20250218-k1-pinctrl-option-v3-1-36e031e0da1b@gentoo.org [1] Link: https://lore.kernel.org/all/6881b8d1ad74ac780af8a974e604b5ef3f5d4aad.1742198691.git.geert+renesas@glider.be [2] > + depends on ARCH_SPACEMIT || COMPILE_TEST > + select MFD_SYSCON > + help > + Say Y to enable clock controller unit support for Spacemit SoCs. > + > +if SPACEMIT_CCU > + > +config SPACEMIT_K1_CCU > + tristate "Support for Spacemit K1 SoC" > + default y ditto > + depends on ARCH_SPACEMIT || COMPILE_TEST > + help > + Support for clock controller unit in Spacemit K1 SoC. > + > +endif -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv