From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD70DC35FFC for ; Sat, 22 Mar 2025 12:06:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WrhQlYuX5ouiDQBS+5pdj0WJ7QkWz+nywpDe/JgkI8Q=; b=MqIPh1xMB2aRXa d7Lt6xyCasIsyyYvV0owJktvmIRiY5TLQIGDy71uEKN769K6TGLb70uHOu9fLkrsxUYaqf8IR52Gn gPeyeED8Ti5VV9+oaWlToVb9B+jIy0TPCrP2suGJIxpw+A6jbxjbbKX4TekCEHjiT1ac05ZL4VP31 QeeLGi6mbqog+NDokZKSShqg5QZXutktVNaV0WsYhv36uYo22jlhSiUZFhfMyfa87uDABz/N1ta4X Op6xqJ49rtdTXJWMGET6ZhSYSdgxslAHCR/plJp9yMEVZGmeS8t9s5c+M6B7Y3wiF2O+7T5CVvWIs vPolL0x1Gq1hGNrVFcMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tvxcB-0000000HN8H-3G7O; Sat, 22 Mar 2025 12:06:11 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tvxc7-0000000HN7N-3yA2 for linux-riscv@lists.infradead.org; Sat, 22 Mar 2025 12:06:10 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-43cfe574976so16828415e9.1 for ; Sat, 22 Mar 2025 05:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1742645166; x=1743249966; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ZKCRWgSlF1v0cutxAi8x3LCFESHSHWoNhfvIYKSJItY=; b=B5y0DZ4YRRNUp2glqxMiBxYI1VKaQ23xpCuvZ5Ai7BE9kn4IEr3hwe8LQSsRj6rXmT ScSEWtNdAsnSAc7ApnhY412/7oJE07X+ce7Y2wWTN26C0ML590cu0G33McBqHfUrjGdh o7GtO8H+kZTxWSG56JEWI9S8rFonbMUqmAANoD1bAfaKOIfcDpmKNLB0jb3qHg8+RPH4 LRHht21Ke4RkdWAbm9AGdY7jeKyA0Doh+tRBml1GgDL16ODimaNv/f/DRfl9P7g8XIGc 3ssCXfeWd6wd7EK3+LmbZNBbztCAdciFN1H9JbFr1n4YKQP6tY44jg1Zga+0kJlibZgC G8DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742645166; x=1743249966; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZKCRWgSlF1v0cutxAi8x3LCFESHSHWoNhfvIYKSJItY=; b=nqK2IeReCia3A+7LKlCJtxEunozE7HoHn8y4DVAIJS/u1h1dRWCxPaxjK9ibP5DHyW NgHPr+FTF3cdCL9LVQ5VDzO9kwIyA+jOtAimMldjXKpDa6dBLnV8GbRyTglBZ67Lmgqa 2ZSikCmXNy9aVVUM2fUVz+c4FAmLUKlq1Ztcl+neKI6BIJ1de5JNKJiXFhNcvCKoJ8IM d4FH0+1S5M6q7rf84/sHIoCV57JKFjUU4+livUL3Ls17khO4KI8Wvsj1XBOweaYb/vGy rAFY9m+dZeDk8vVbmUzPtEZrphKBUtlh5KwBvN1ejA9G7e3VTBE2MuaB1Yt7VM7DPfLN tZIg== X-Forwarded-Encrypted: i=1; AJvYcCXRf6UICQRCK4WU/mncw3Ft18XAgwpWhZlTCBHykCDeY23+OGyASQ3LTM/FeVLemHPVMTN7IlPzPe7wdw==@lists.infradead.org X-Gm-Message-State: AOJu0YzpJhGdLfQGkBpTvbBw4BJgAwoj26UrZxLTIjkU8m6HqZS1mnDr 5EZzXm96/UOpVhb8YKApyAlqvHo07nmqcurb1lwnPN7M5tkxF9+6hOa48Keq6VM= X-Gm-Gg: ASbGncvRRMmw1SfgaQw773FGgpcr8mSM1VMEgi9GGxYl3DGXw6xQfm1N1AZeUKZTo+j R9ttetaCrcsVtO361cyV343T5/gqDB1Ld9YUrC7PaDGo4c1tbDokATN2Yg9rrOl6cEWtdWiml0P IbVeY9iA3mtoaHIKyzjYEuCjVvfQv3H9ItM12MtJ6ByNsJplCGkxxWo7LvLwczTYo/aCtHXA+OS gSl/PUEmn4eM6JJeh9SwCLJQzFaElFQiXgJA9biUhIdyghXT+i+PH9idoh2Dk2L8J+i0SllBkQ3 a0RI1fnkVr3i1gUhvn4vzfMZ9Frbp9J151JYe/QDqkG+hKSWh0sU4kLkh9deSr64YCTKeBAAbw= = X-Google-Smtp-Source: AGHT+IFTfC3V3Y+aXvtwsAGDzN2r/TELBK33hItKDRr/I6qX4Pf8OQOcC8wMhwn6dPn+tHwLQGn1PA== X-Received: by 2002:a05:600c:470f:b0:43c:fe15:41e1 with SMTP id 5b1f17b1804b1-43d509e190fmr61771675e9.4.1742645165642; Sat, 22 Mar 2025 05:06:05 -0700 (PDT) Received: from localhost (cst2-173-28.cust.vodafone.cz. [31.30.173.28]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3997f9ef23esm4932401f8f.81.2025.03.22.05.06.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Mar 2025 05:06:05 -0700 (PDT) Date: Sat, 22 Mar 2025 13:06:04 +0100 From: Andrew Jones To: =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= Cc: Paul Walmsley , Palmer Dabbelt , Anup Patel , Atish Patra , Shuah Khan , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org, Samuel Holland Subject: Re: [PATCH v4 02/18] riscv: sbi: add new SBI error mappings Message-ID: <20250322-cce038c88db88dd119a49846@orel> References: <20250317170625.1142870-1-cleger@rivosinc.com> <20250317170625.1142870-3-cleger@rivosinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250317170625.1142870-3-cleger@rivosinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250322_050607_988402_2C04720B X-CRM114-Status: GOOD ( 14.02 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Mar 17, 2025 at 06:06:08PM +0100, Cl=E9ment L=E9ger wrote: > A few new errors have been added with SBI V3.0, maps them as close as > possible to errno values. > = > Signed-off-by: Cl=E9ment L=E9ger > --- > arch/riscv/include/asm/sbi.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > = > diff --git a/arch/riscv/include/asm/sbi.h b/arch/riscv/include/asm/sbi.h > index bb077d0c912f..d11d22717b49 100644 > --- a/arch/riscv/include/asm/sbi.h > +++ b/arch/riscv/include/asm/sbi.h > @@ -536,11 +536,20 @@ static inline int sbi_err_map_linux_errno(int err) > case SBI_SUCCESS: > return 0; > case SBI_ERR_DENIED: > + case SBI_ERR_DENIED_LOCKED: > return -EPERM; > case SBI_ERR_INVALID_PARAM: > + case SBI_ERR_INVALID_STATE: > + case SBI_ERR_BAD_RANGE: > return -EINVAL; > case SBI_ERR_INVALID_ADDRESS: > return -EFAULT; > + case SBI_ERR_NO_SHMEM: > + return -ENOMEM; > + case SBI_ERR_TIMEOUT: > + return -ETIME; > + case SBI_ERR_IO: > + return -EIO; > case SBI_ERR_NOT_SUPPORTED: > case SBI_ERR_FAILURE: > default: > -- = > 2.47.2 > I'm not a huge fan sbi_err_map_linux_errno() since the mappings seem a bit arbitrary, but if we're going to do it, then these look pretty good to me. Only other thought I had was E2BIG for bad-range, but nah... Reviewed-by: Andrew Jones Thanks, drew _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv