From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 290B2C35FFC for ; Tue, 25 Mar 2025 10:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mXo32Xwa4WVVAntorM1fVYa+/L+jiixHNQAGEufs+Vc=; b=ohmt0JbOE0gODZ zoszPAHQpMyl4T2+ESZ5lbINsYblmFR3Kvj8OnTt+PWJho+S8v+yKVLv1hUl4iZppa7PR5YqCVlfU 2tLn3ubutzt2Qo1vwkxEkroWs0cA8KU+8ciOKx1CgRf2c+4cB6aTX7qM14xA1pyjaBG6BnSHUh1MG RiDZEBhrPo+TZXecMhi/hpCIMPKCyhYa14I7mwSFKcvaFhe4lFRFOiy38DH7OzmO4NUhwfKWfXA81 rdeGJBlKud183E06DUQdPb/EMbLWJ4hLgawrHXlo06Ox9I3SMybYBdmjpTFr7CYo7AI1/KjfDyje5 6F6F3FuZShvXBEx5+Nfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tx15R-00000005NjE-0Tl9; Tue, 25 Mar 2025 10:00:45 +0000 Received: from woodpecker.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4] helo=smtp.gentoo.org) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tx15O-00000005NiC-39LS for linux-riscv@lists.infradead.org; Tue, 25 Mar 2025 10:00:43 +0000 Received: from localhost (unknown [116.232.48.233]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id 0A6BD34332A; Tue, 25 Mar 2025 10:00:39 +0000 (UTC) Date: Tue, 25 Mar 2025 10:00:35 +0000 From: Yixun Lan To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Conor Dooley , Paul Walmsley , Palmer Dabbelt Subject: Re: [PATCH v7 2/4] gpio: spacemit: add support for K1 SoC Message-ID: <20250325100035-GYA22564@gentoo> References: <20250226-03-k1-gpio-v7-0-be489c4a609b@gentoo.org> <20250226-03-k1-gpio-v7-2-be489c4a609b@gentoo.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250226-03-k1-gpio-v7-2-be489c4a609b@gentoo.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250325_030042_815866_9A335194 X-CRM114-Status: GOOD ( 14.58 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Meng Zhang , Alex Elder , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Jesse Taube , Yangyu Chen , Inochi Amaoto , Jisheng Zhang , linux-riscv@lists.infradead.org, spacemit@lists.linux.dev Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi All: The gpio controller request clocks to work, I will address this in next version also will On 08:41 Wed 26 Feb , Yixun Lan wrote: > Implement GPIO functionality which capable of setting pin as > input, output. Also, each pin can be used as interrupt which > support rising, falling, or both edge type trigger. > > Reviewed-by: Alex Elder > Reviewed-by: Linus Walleij > Signed-off-by: Yixun Lan > --- > drivers/gpio/Kconfig | 8 ++ > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-spacemit-k1.c | 277 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 286 insertions(+) > + ... > +static int spacemit_gpio_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct spacemit_gpio *sg; > + struct resource *res; > + void __iomem *regs; > + int i, irq, ret; > + > + sg = devm_kzalloc(dev, sizeof(*sg), GFP_KERNEL); > + if (!sg) > + return -ENOMEM; > + > + regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res); will update to devm_platform_ioremap_resource() to get rid of &res parameter -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv