Re: [RFC PATCH v2 2/9] dt-bindings: soc: microchip: document the simple-mfd syscon on PolarFire SoC

Krzysztof Kozlowski
2025-03-25T08:13:34Z

On Fri, Mar 21, 2025 at 05:22:35PM +0000, Conor Dooley wrote:
> +title: Microchip PolarFire SoC Microprocessor Subsystem (MSS) sysreg register region
> +
> +maintainers:
> + - Conor Dooley <conor.dooley@microchip.com>
> +
> +description:
> + An wide assortment of registers that control elements of the MSS on PolarFire
> + SoC, including pinmuxing, resets and clocks among others.
> +
> +properties:
> + compatible:
> + items:
> + - const: microchip,mpfs-mss-top-sysreg
> + - const: syscon
> + - const: simple-mfd

You need to list the children if you use simple-mfd. Commit msg
mentioned clock controller, so where is it?

> +
> + reg:
> + maxItems: 1
> +
> + '#reset-cells':
> + description:
> + The AHB/AXI peripherals on the PolarFire SoC have reset support, so
> + from CLK_ENVM to CLK_CFM. The reset consumer should specify the
> + desired peripheral via the clock ID in its "resets" phandle cell.
> + See include/dt-bindings/clock/microchip,mpfs-clock.h for the full list
> + of PolarFire clock/reset IDs.
> + const: 1

Best regards,
Krzysztof