From: Greg KH <gregkh@linuxfoundation.org>
To: Ryo Takakura <ryotkkr98@gmail.com>
Cc: alex@ghiti.fr, aou@eecs.berkeley.edu, jirislaby@kernel.org,
john.ogness@linutronix.de, palmer@dabbelt.com,
paul.walmsley@sifive.com, pmladek@suse.com,
samuel.holland@sifive.com, bigeasy@linutronix.de,
conor.dooley@microchip.com, u.kleine-koenig@baylibre.com,
lkp@intel.com, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-serial@vger.kernel.org,
stable@vger.kernel.org, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v2 1/2] serial: sifive: lock port in startup()/shutdown() callbacks
Date: Sun, 30 Mar 2025 09:30:27 +0200 [thread overview]
Message-ID: <2025033015-blanching-pagan-db09@gregkh> (raw)
In-Reply-To: <20250330011610.388077-1-ryotkkr98@gmail.com>
On Sun, Mar 30, 2025 at 10:16:10AM +0900, Ryo Takakura wrote:
> startup()/shutdown() callbacks access SIFIVE_SERIAL_IE_OFFS.
> The register is also accessed from write() callback.
>
> If console were printing and startup()/shutdown() callback
> gets called, its access to the register could be overwritten.
>
> Add port->lock to startup()/shutdown() callbacks to make sure
> their access to SIFIVE_SERIAL_IE_OFFS is synchronized against
> write() callback.
>
> Signed-off-by: Ryo Takakura <ryotkkr98@gmail.com>
> Cc: stable@vger.kernel.org
> ---
>
> Hi,
>
> I'm sorry that I wasn't aware of how Cc stable should be done.
>
> I added Cc for stable but please tell me if this patch should be
> resent or if there is any that is missing.
Please resend a v3.
thanks,
greg k-h
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-03-30 7:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Z-iSb0ryR-tiUCj0@42be267012b8>
2025-03-30 1:16 ` [PATCH v2 1/2] serial: sifive: lock port in startup()/shutdown() callbacks Ryo Takakura
2025-03-30 7:30 ` Greg KH [this message]
2025-03-30 10:51 ` Ryo Takakura
2025-03-30 0:30 [PATCH v2 0/2] serial: sifive: Convert sifive console to nbcon Ryo Takakura
2025-03-30 0:35 ` [PATCH v2 1/2] serial: sifive: lock port in startup()/shutdown() callbacks Ryo Takakura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025033015-blanching-pagan-db09@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=bigeasy@linutronix.de \
--cc=conor.dooley@microchip.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pmladek@suse.com \
--cc=ryotkkr98@gmail.com \
--cc=samuel.holland@sifive.com \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox