From: Rob Herring <robh@kernel.org>
To: "Uwe Kleine-König" <ukleinek@kernel.org>
Cc: Longbin Li <looong.bin@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen Wang <unicorn_wang@outlook.com>,
Inochi Amaoto <inochiama@gmail.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>, ghost <2990955050@qq.com>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
sophgo@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: pwm: sophgo: add pwm controller for SG2044
Date: Mon, 7 Apr 2025 09:11:19 -0500 [thread overview]
Message-ID: <20250407141119.GA2192351-robh@kernel.org> (raw)
In-Reply-To: <jq55x7uhftvejninh56tzk32jtmmwa5wxzna5uxbkk5woi7zi5@6wrg2ctmyg7b>
On Mon, Apr 07, 2025 at 02:31:24PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Mon, Apr 07, 2025 at 03:20:38PM +0800, Longbin Li wrote:
> > diff --git a/Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml b/Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml
> > index bbb6326d47d7..e0e91aa237ec 100644
> > --- a/Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml
> > +++ b/Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml
> > @@ -17,7 +17,9 @@ allOf:
> >
> > properties:
> > compatible:
> > - const: sophgo,sg2042-pwm
> > + enum:
> > + - sophgo,sg2042-pwm
> > + - sophgo,sg2044-pwm
>
> Given that the sg2044 has more registers (to e.g. implement different
> polarity), but the sg2042 registers are identical, I wonder if the 2044
> device should use:
>
> compatible = "sophgo,sg2044-pwm", "sophgo,sg2042-pwm";
>
> Note, I'm unsure here, only providing input to people who are more
> knowledgeable in DT that I am.
Depends if s/w only understanding "sophgo,sg2042-pwm" will work on the
2044. IOW, will a kernel without the driver change here work?
Rob
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-04-07 14:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 7:20 [PATCH 0/2] riscv: pwm: sophgo: add pwm support for SG2044 Longbin Li
2025-04-07 7:20 ` [PATCH 1/2] dt-bindings: pwm: sophgo: add pwm controller " Longbin Li
2025-04-07 12:31 ` Uwe Kleine-König
2025-04-07 14:11 ` Rob Herring [this message]
2025-04-08 2:33 ` Inochi Amaoto
2025-04-09 7:57 ` Krzysztof Kozlowski
2025-04-07 7:20 ` [PATCH 2/2] pwm: sophgo: add driver " Longbin Li
2025-04-07 9:38 ` Uwe Kleine-König
2025-04-07 10:02 ` Longbin Li
2025-04-07 15:30 ` kernel test robot
2025-04-08 1:02 ` Chen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407141119.GA2192351-robh@kernel.org \
--to=robh@kernel.org \
--cc=2990955050@qq.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=looong.bin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=sophgo@lists.linux.dev \
--cc=ukleinek@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox