From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6B9CC369AB for ; Tue, 15 Apr 2025 12:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FW//Nquui7PDKJ2pjlK5N/Lsd6O5Mvwj+j2jVI+XduA=; b=AAMQbObxcO8egt sx/zKkhnaS9M49f1XN0cR8EME+PRSlak/NWy+10WQNgBox6eVIo6t3Q9f5OuzSgvsU3L6dHxpQL2x ejsDzGbHXY4xW8idkxYspWJRPkVWrbnZAF0YfQqiIn9FmkX84Y3jscm2eHD6Y2CTHj2IliefEzS5Y 8fhQqv+C/9SI10BcY50fI4usjJAbXir8FJ9owMUe9ZJzzpynJenl+eyNfGBT7ay3Fs0U5vVK2kaDX E/cMlckxEBa/KkhsLeNxAkoXiZykzEemteg3nf5eOpJtIN9BSoK79PFkv+4R13t/zYh6l77MKXqlt 1ld7WMVVi+vARMoshAvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4ff4-00000005npo-1Gfx; Tue, 15 Apr 2025 12:45:10 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4fYL-00000005mat-1e23; Tue, 15 Apr 2025 12:38:14 +0000 Date: Tue, 15 Apr 2025 14:38:07 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1744720690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nzawNatPbq1ZNSb9ZVxi6008X2uDX4ctY3uXm4ZDLKc=; b=Ejf15B0G6V/V4b0G5v0K7G9W/9PynAnMz3ByOriTZzIq8uLtTwq/TztJPm7gIviwMkz3Kf n+SAP8ZLJmyRV4ouj/H8QqBot3o0aMi9V62ibzRBZeqYQNt9ouocjl5uL2ME39YppXevRm G+wBc3EWYtn29qYJ1fzP/Wmm8gtqH5SWS7kcaOUl2JGCN5TQilRLROj+NKi2XjHwtSvD+Y 3NBL+oppuHwSju1FksExSQsk5xOTKagBDpX8Xfp5DA4wuUgeD99x+ITsWklHKRKdiY2P2K df+fVysMmQJa8BtbWzr86y5i0Yp1xh7BFjend7Z4zqMUVxuk8KhEBJXosw8rDg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1744720690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nzawNatPbq1ZNSb9ZVxi6008X2uDX4ctY3uXm4ZDLKc=; b=uXHBILYw21rrPrwmTaF++U0ZD1onpTceW7OBoUTuHRM0SLb3jzBEUCaGIaT9v6RAqz0WIp NxpopC2Q8LmvviAQ== From: Nam Cao To: Gabriele Monaco Cc: Steven Rostedt , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, john.ogness@linutronix.de, Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Peter Zijlstra , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 19/22] rv: Add rtapp_pagefault monitor Message-ID: <20250415123807.2MahJd60@linutronix.de> References: <4d5dd1b919aada32ddf4dbce895f19e558343ee9.camel@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4d5dd1b919aada32ddf4dbce895f19e558343ee9.camel@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250415_053813_570583_14FAFB7D X-CRM114-Status: GOOD ( 12.93 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Apr 15, 2025 at 02:31:43PM +0200, Gabriele Monaco wrote: > On Fri, 2025-04-11 at 09:37 +0200, Nam Cao wrote: > > +static int __init register_pagefault(void) > > +{ > > + rv_register_monitor(&rv_pagefault, &rv_rtapp); > > + return 0; > > Any reason why you aren't returning the error value from the monitor > registration? Copy-paste from dot2k :P > Other than that, the monitor seems neat and reasonably easy to > generate. > > May not be necessary in this series, but try to keep compatibility with > the userspace RV tool as well, you need to have some special case in > its tracing components because fields are not matching: > # rv mon sleep -t > rcuc/11-108 [011] event > (null) x (null) -> (null) Y > rcuc/11-108 [011] event > (null) x (null) -> (null) Y > ktimers/11-109 [011] event > (null) x (null) -> (null) Y I have this userspace RV tool in my "later" TODO list, if that's okay. Honestly, I haven't looked at what it does yet. perf already does what I need. Best regards, Nam _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv