Re: [PATCH 00/15] Finish disentangling ChaCha, Poly1305, and BLAKE2s from CRYPTO

Ard Biesheuvel
2025-04-18T14:21:41Z

On Thu, 17 Apr 2025 at 20:27, Eric Biggers <ebiggers@kernel.org> wrote:
>
> This series removes the unnecessary dependency of the ChaCha, Poly1305,
> and BLAKE2s library functions on the generic crypto infrastructure, i.e.
> CONFIG_CRYPTO. To do this, it moves arch/*/crypto/Kconfig from a
> submenu of crypto/Kconfig to a submenu of arch/*/Kconfig, then re-adds
> the CRYPTO dependency to the symbols that actually need it.
>
> Patches 14-15 then simplify the ChaCha and Poly1305 symbols by removing
> the unneeded "internal" symbols.
>
> Note that Curve25519 is still entangled. Later patches will fix that.
>
> Eric Biggers (15):
> crypto: arm - remove CRYPTO dependency of library functions
> crypto: arm64 - drop redundant dependencies on ARM64
> crypto: arm64 - remove CRYPTO dependency of library functions
> crypto: loongarch - source arch/loongarch/crypto/Kconfig without
> CRYPTO
> crypto: mips - remove CRYPTO dependency of library functions
> crypto: powerpc - drop redundant dependencies on PPC
> crypto: powerpc - remove CRYPTO dependency of library functions
> crypto: riscv - remove CRYPTO dependency of library functions
> crypto: s390 - drop redundant dependencies on S390
> crypto: s390 - remove CRYPTO dependency of library functions
> crypto: sparc - source arch/sparc/crypto/Kconfig without CRYPTO
> crypto: x86 - drop redundant dependencies on X86
> crypto: x86 - remove CRYPTO dependency of library functions
> crypto: lib/chacha - remove INTERNAL symbol and selection of CRYPTO
> crypto: lib/poly1305 - remove INTERNAL symbol and selection of CRYPTO
>

This seems like a good idea.

Acked-by: Ard Biesheuvel <ardb@kernel.org>