Re: [PATCH 01/15] crypto: arm - remove CRYPTO dependency of library functions

Eric Biggers
2025-04-18T04:12:52Z

On Fri, Apr 18, 2025 at 11:38:46AM +0800, Herbert Xu wrote:
> On Thu, Apr 17, 2025 at 08:32:36PM -0700, Eric Biggers wrote:
> >
> > I don't think that would be better. The 'if' would be up to 400 lines long, and
> > it would be easy for people to miss the context when editing the file.
>
> We should separate the symbols for Crypto API options and the library
> options. If you're worried about people missing the if statement,
> how about splitting the file into two? One for Crypto API symbols
> and one for the library symbols.
>
> In fact we could move the library files into a different directory,
> e.g., arch/x86/crypto/lib or arch/x86/lib/crypto.

arch/$ARCH/lib/crypto/ is the "right" way to do it, mirroring lib/crypto/. I
was just hoping to avoid a 4-deep directory. But we can do it.

- Eric